Skip to content

fix(appengine): hardcoded PORT -> env var#8145

Merged
ace-n merged 1 commit into
mainfrom
fix-b237096040
Jun 30, 2022
Merged

fix(appengine): hardcoded PORT -> env var#8145
ace-n merged 1 commit into
mainfrom
fix-b237096040

Conversation

@ace-n
Copy link
Copy Markdown

@ace-n ace-n commented Jun 30, 2022

Fixes b/237096040

@ace-n ace-n requested review from a team as code owners June 30, 2022 21:42
@product-auto-label product-auto-label Bot added api: appengine Issues related to the App Engine Admin API API. samples Issues that are directly related to samples. labels Jun 30, 2022
Copy link
Copy Markdown
Contributor

@iennae iennae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iennae
Copy link
Copy Markdown
Contributor

iennae commented Jun 30, 2022

I'm wondering whether this should have a comment inline with the code as to the expectation for the variable. Thoughts @dandhlee ?

For java we have https://github.com/GoogleCloudPlatform/java-docs-samples/blob/HEAD/appengine-java11/http-server/src/main/java/com/example/appengine/Main.java#L27-L28; the code is slightly different in it has a fallback to 8080 if the variable isn't defined, but it feels helpful to me to define.

@dandhlee
Copy link
Copy Markdown
Collaborator

I think it's better to leave this one as-is, and add comments elsewhere. This code seems to show up embedded in this doc: https://cloud.google.com/appengine/docs/standard/python3/runtime.md, which I think comment there would help more than an inline comment here and then the doc looking slightly weird.

@dandhlee
Copy link
Copy Markdown
Collaborator

If this file had a lot more code I think it'd be worth having comments, but it's such a short file already :/

@iennae
Copy link
Copy Markdown
Contributor

iennae commented Jun 30, 2022

Thanks so much @dandhlee :)

@ace-n ace-n merged commit c9b8e4e into main Jun 30, 2022
@ace-n ace-n deleted the fix-b237096040 branch June 30, 2022 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: appengine Issues related to the App Engine Admin API API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants