Skip to content

fix(storage): add backoff to retry flaky test #7582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cojenco merged 3 commits into from
Mar 14, 2022
Merged

fix(storage): add backoff to retry flaky test #7582

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bf447e8
fix(storage): add backoff to retry flaky test
cojenco Mar 10, 2022
dc42739
fix lint
cojenco Mar 11, 2022
5e5c1a5
Merge branch 'main' into sts7578
cojenco Mar 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 19 additions & 11 deletions storagetransfer/check_latest_transfer_operation_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,7 @@


@pytest.fixture()
def transfer_job(
project_id: str, source_bucket: Bucket, destination_bucket: Bucket):
# Create job
def transfer_job(project_id: str, source_bucket: Bucket, destination_bucket: Bucket):
client = storage_transfer.StorageTransferServiceClient()
transfer_job = {
"description": "Sample job",
Expand All @@ -53,18 +51,28 @@ def transfer_job(
"delete_objects_from_source_after_transfer": True},
},
}
result = client.create_transfer_job({"transfer_job": transfer_job})

# Create job
@backoff.on_exception(backoff.expo, HttpError, max_time=60)
def create_job():
return client.create_transfer_job({"transfer_job": transfer_job})

result = create_job()

yield result.name

# Remove job
client.update_transfer_job({
"job_name": result.name,
"project_id": project_id,
"transfer_job": {
"status": storage_transfer.TransferJob.Status.DELETED
}
})
@backoff.on_exception(backoff.expo, HttpError, max_time=60)
def remove_job():
client.update_transfer_job(
{
"job_name": result.name,
"project_id": project_id,
"transfer_job": {"status": storage_transfer.TransferJob.Status.DELETED},
}
)

remove_job()


@backoff.on_exception(backoff.expo, (RetryError,), max_time=60)
Expand Down