add note about using finally#7314
Merged
Merged
Conversation
@tswast reminded me about `finally` the other day and I thought I'd add a note about it in the authoring guide
tswast
approved these changes
Jan 5, 2022
dandhlee
reviewed
Jan 6, 2022
Collaborator
dandhlee
left a comment
There was a problem hiding this comment.
It is a large document but I think without the examples it can be easily glanced over. Could you include the example snippets in the document directly rather than referencing it through the link? I think this is a great example that should be stood out rather than have the chance of this slipping through the reader when they skim through the authoring guide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@tswast reminded me about
finallythe other day and I thought I'd add a note about it in the authoring guide