fix: Update logging library#6472
Merged
Merged
Conversation
This was
linked to
issues
Jul 26, 2021
dandhlee
reviewed
Jul 26, 2021
dandhlee
approved these changes
Jul 26, 2021
| # If there are any results, exit loop | ||
| break | ||
| # When message found, exit loop | ||
| if found is True: |
Collaborator
There was a problem hiding this comment.
nit: if found: should be good enough.
busunkim96
approved these changes
Jul 27, 2021
Contributor
busunkim96
left a comment
There was a problem hiding this comment.
@daniel-sanche Could you check the logging library is being used as you expect? Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5697
Note: It's a good idea to open an issue first for discussion.
Checklist
nox -s py-3.6(see Test Environment Setup)nox -s lint(see Test Environment Setup)