docs(firestore): clean-up region tagging#5893
Conversation
|
Committed updates for 2/4 region tags that were in violation (on devsite). The remaining two found in Quickstart docs are false positives, awaiting updates from cl/376017137. |
|
@Strykrol I think the checks on For example, this page: python-docs-samples/firestore/cloud-client/snippets.py Lines 38 to 45 in ca852da But I may be wrong. Why do you think it's a false positive? The link has commit hash, so it might be ok, but the fact that the master branch doesn't have the same region tag is still confusing. |
|
For a record, the html element has the following property: So I assume the devsite build will break if we remove this region tag now. |
|
@tmatsuo let's talk offline - I'm not seeing what you're seeing, but the source file for that page doesn't appear to me to have these region tags anymore. |
|
Looks like the violations resolved after we manually re-published last week. |
dandhlee
left a comment
There was a problem hiding this comment.
LGTM, minor license header issue. Please see comment below
|
One more minor lint issue then we should be good: |
|
Done |
|
Thank you! Merged as crwilcox@ is part of |
Checklist