Add retry sample to STS#5760
Merged
Merged
Conversation
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
frankyn
approved these changes
Apr 28, 2021
Contributor
frankyn
left a comment
There was a problem hiding this comment.
Nice catch Jesse! This LGTM
leahecole
requested changes
Apr 30, 2021
Collaborator
leahecole
left a comment
There was a problem hiding this comment.
Just some silly little nits and an update to the retry just to make sure it doesn't pass on another hypothetical random 3
| print( | ||
| "Fetched transfer job: " | ||
| + transferJob.get("name") | ||
| + " using {} retries".format(retries) |
Collaborator
There was a problem hiding this comment.
nit - can you switch this to f-strings?
Member
Author
There was a problem hiding this comment.
I believe f strings aren't compatible with python 2.7 which we do have kokoro tests for, am I mistaken?
leahecole
approved these changes
May 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example retry code on the STS docs page is both incorrect and in-line, this adds a proper sample that simply executes a request using retries to replace it