Pub/Sub: enable parallel writes to GCS in Pub/Sub Dataflow example#5547
Merged
Conversation
6bb2439 to
1409bc1
Compare
davidcavazos
approved these changes
Mar 19, 2021
davidcavazos
left a comment
There was a problem hiding this comment.
Thanks for the explanation, I have some minor comments, but overall LGTM!
|
Looks great! Thanks for these improvements, LGTM! |
hongalex
approved these changes
Mar 19, 2021
busunkim96
approved these changes
Mar 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5441
Used this opportunity to update comments and clean up this example too.
Tried
Splittable DoFnbut the documentation on parallel writes is very slim, and the Python support lags behind Java.