Adding e2e_test for Cloud Run image processing sample#4852
Merged
Conversation
Contributor
dinagraves
commented
Oct 14, 2020
- Uploads image to one storage bucket
- Pub/Sub Notification to Cloud Run service
- Uploads blurred image to another storage bucket
grant
approved these changes
Oct 15, 2020
averikitsch
reviewed
Oct 15, 2020
| def pubsub_topic(service_url): | ||
| # Create pub/sub topic | ||
| topic = f"image_proc_{SUFFIX}" | ||
| subprocess.run( |
Contributor
There was a problem hiding this comment.
This is all really great, but in the future would it be better to this to be set up as a part of cloud build?
Contributor
Author
There was a problem hiding this comment.
Good question -- I didn't go down that road b/c the Cloud Build service agent didn't have pub/sub permissions in this project, but obviously we could update the permissions.
averikitsch
approved these changes
Oct 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.