Skip to content

chore(functions): remove redundant logging sample#4441

Merged
tmatsuo merged 2 commits intomasterfrom
rm-log
Aug 27, 2020
Merged

chore(functions): remove redundant logging sample#4441
tmatsuo merged 2 commits intomasterfrom
rm-log

Conversation

@ace-n
Copy link
Copy Markdown

@ace-n ace-n commented Aug 5, 2020 •
edited
Loading

Do not merge until the translated docs have been updated.

Part of b/162963392

@ace-n ace-n requested a review from engelke August 5, 2020 20:39
@ace-n ace-n requested a review from a team as a code owner August 5, 2020 20:39
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 5, 2020
@ace-n ace-n added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 5, 2020
engelke
engelke approved these changes Aug 11, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ace-n ace-n requested a review from a team August 18, 2020 01:00
@ace-n
Copy link
Copy Markdown
Author

ace-n commented Aug 18, 2020

@GoogleCloudPlatform/python-samples-owners second LGTM please? 😄

@ace-n
Copy link
Copy Markdown
Author

ace-n commented Aug 21, 2020

@tmatsuo mind reviewing?

Also, can you merge once this is LGTM?

@ace-n ace-n removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 21, 2020
@product-auto-label product-auto-label bot added api: cloudfunctions Issues related to the Cloud Run functions API. samples Issues that are directly related to samples. labels Aug 21, 2020
@tmatsuo tmatsuo merged commit 558beb6 into master Aug 27, 2020
@tmatsuo tmatsuo deleted the rm-log branch August 27, 2020 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@tmatsuo tmatsuo tmatsuo approved these changes

@engelke engelke engelke approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tmatsuo tmatsuo

@engelke engelke

Labels

api: cloudfunctions Issues related to the Cloud Run functions API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ace-n @tmatsuo @engelke