[ABANDONED] draft of DRIFT region tag tracking#4402
Closed
ace-n wants to merge 10 commits into
Closed
Conversation
tmatsuo
reviewed
Aug 3, 2020
| EXIT=$? | ||
|
|
||
| # Inject region tag data into the test log | ||
| REGION_TAG_PARSER_DIR="$PARENT_DIR/region-tag-parser" |
Contributor
There was a problem hiding this comment.
Can you use a temporary directory? Also it's great if you make sure the temporary directory will be deleted after the test.
Contributor
There was a problem hiding this comment.
Update: maybe you can just install them in /opt or somewhere then it will only exists in the container.
/tmp is shared between the container and the host for a reason, so it's probably better to use somewhere else.
Author
|
FYI - this is a draft PR. (No review necessary until I actually get this
working. 🙂 )
|
2d097ee to
392f8b1
Compare
Contributor
|
FYI, you can run the whole test locally. Here is an example for running lint full build: $ cd python-docs-samples
$ TRAMPOLINE_BUILD_FILE=.kokoro/tests/run_tests.sh RUN_TESTS_SESSION=lint .kokoro/trampoline_v2.shFor python sessions, you probably want to have secrets locally: $ cd python-docs-samples
$ scripts/decrypt-secrets.sh # You need permission of course
$ TRAMPOLINE_BUILD_FILE=.kokoro/tests/run_tests.sh RUN_TESTS_SESSION=py-3.7 .kokoro/trampoline_v2.shIf you want to use your own Cloud projects: $ cd python-docs-samples
$ cp testing/test-env.tmpl.sh testing/test-env.sh # and edit it
$ cp /some/where/your-service-account-json.key testing/service-account.json
$ TRAMPOLINE_BUILD_FILE=.kokoro/tests/run_tests.sh RUN_TESTS_SESSION=py-3.7 .kokoro/trampoline_v2.shThis way, it will run the tests in an identical way as on Kokoro builds, so you can develop it locally without pushing any changes. |
Author
|
@tmatsuo thanks! I think this needs to be run on Kokoro itself though, as part of what I'm testing is the ability to export these test results (which I think happens outside the immediate build context). |
Closed
3 tasks
Author
|
Closing in favor of #4506 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.