Skip to content

[jobs] testing: use multiple projects#3973

Merged
tmatsuo merged 5 commits into
GoogleCloudPlatform:masterfrom
tmatsuo:fix-jobs
Jun 8, 2020
Merged

[jobs] testing: use multiple projects#3973
tmatsuo merged 5 commits into
GoogleCloudPlatform:masterfrom
tmatsuo:fix-jobs

Conversation

@tmatsuo
Copy link
Copy Markdown
Contributor

@tmatsuo tmatsuo commented Jun 5, 2020

fixes #3969

@tmatsuo tmatsuo requested a review from leahecole June 5, 2020 01:25
@tmatsuo tmatsuo requested a review from a team as a code owner June 5, 2020 01:25
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 5, 2020
@tmatsuo tmatsuo added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 5, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 5, 2020
@tmatsuo
Copy link
Copy Markdown
Contributor Author

tmatsuo commented Jun 5, 2020

It's concerning to see the same quota error even with using multiple projects.
I'll dig a bit deeper.

@tmatsuo
Copy link
Copy Markdown
Contributor Author

tmatsuo commented Jun 5, 2020 •
edited
Loading

I actually check the quota value and found that the quota is 6 for quota metric that handles periodic task requests (searchForAlert) per minute. This is very low.

I'm going to let the test wait more between retries.

Update: I also requested to bump this quota to 24.

@tmatsuo
Copy link
Copy Markdown
Contributor Author

tmatsuo commented Jun 5, 2020

A different test is failing for different reason.

@tmatsuo tmatsuo added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 5, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 5, 2020
@tmatsuo tmatsuo added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 5, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 5, 2020
leahecole
leahecole reviewed Jun 5, 2020
View reviewed changes
Copy link
Copy Markdown
Collaborator

@leahecole leahecole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious about the readme changes and if they affect the whole multiple projects thing? Just want to understand better what's going on.

@tmatsuo
Copy link
Copy Markdown
Contributor Author

tmatsuo commented Jun 5, 2020 •
edited
Loading

@leahecole

During the process of opting in to use multiple projects, usually I need to do some setup tasks. For example, in this case, I needed to enable the API, also needed to opt in to data logging (although I don't know what exactly it is), and add a role.

Whenever I go through this process, I try to document the required process as much as possible. For example, in this case, I added some fields in the README.rst.in. Then I needed to re-generate the README.

Does it make sense?

@tmatsuo tmatsuo requested a review from leahecole June 5, 2020 22:28
@tmatsuo tmatsuo merged commit 759db93 into GoogleCloudPlatform:master Jun 8, 2020
@tmatsuo tmatsuo deleted the fix-jobs branch June 8, 2020 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leahecole leahecole leahecole approved these changes

Assignees

@leahecole leahecole

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

jobs failed in py 3.6 for a google-auth PR

4 participants

@tmatsuo @leahecole @googlebot @kokoro-team