Skip to content

update iap to use google-auth for id_token#3444

Merged
bshaffer merged 17 commits intoGoogleCloudPlatform:masterfrom
arithmetic1728:master
Apr 23, 2020
Merged

update iap to use google-auth for id_token#3444
bshaffer merged 17 commits intoGoogleCloudPlatform:masterfrom
arithmetic1728:master

Conversation

@arithmetic1728
Copy link
Copy Markdown
Contributor

No description provided.

@arithmetic1728 arithmetic1728 requested a review from a team as a code owner April 20, 2020 21:26
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 20, 2020
@arithmetic1728 arithmetic1728 marked this pull request as draft April 20, 2020 21:26
Copy link
Copy Markdown
Contributor

@gguuss gguuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a language perspective, maybe get @ace-n to review from the perspective of product and let us know when it's ready.

@arithmetic1728
Copy link
Copy Markdown
Contributor Author

@gguuss Thank you!

@bshaffer Could you take a look at the implementation?

@arithmetic1728 arithmetic1728 marked this pull request as ready for review April 22, 2020 22:22
@gguuss gguuss assigned bshaffer and unassigned gguuss Apr 22, 2020
Copy link
Copy Markdown
Contributor

@bshaffer bshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran these samples with my own client ID and URL, and everything worked as expected. Well done!

Comment thread iap/make_iap_request.py Outdated
@bshaffer bshaffer merged commit 5ef84ba into GoogleCloudPlatform:master Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants