Skip to content

Added config for using Memorystore (Redis) with App Engine standard P…#2921

Merged
busunkim96 merged 8 commits into
masterfrom
app-engine-py2-memorystore
Apr 9, 2020
Merged

Added config for using Memorystore (Redis) with App Engine standard P…#2921
busunkim96 merged 8 commits into
masterfrom
app-engine-py2-memorystore

Conversation

@michaelawyu
Copy link
Copy Markdown
Contributor

…ython 2 runtime

@michaelawyu michaelawyu requested a review from a team as a code owner February 15, 2020 00:47
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 15, 2020
@michaelawyu michaelawyu requested a review from andrewsg February 15, 2020 01:21
@michaelawyu
Copy link
Copy Markdown
Contributor Author

This sample is originally shared among 4 environments: GCE, GKE, App Engine (Standard/Python 3) and App Engine (Flexible). Some of the dependencies are neither compatible with Python 2 nor needed in the old environment, hence the exclusion from Python 2 tests.

Copy link
Copy Markdown
Member

@andrewsg andrewsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment thread memorystore/redis/gae_standard_py2_deployment/app.yaml
@busunkim96 busunkim96 added the automerge Merge the pull request once unit tests and other checks pass. label Apr 9, 2020
@gcf-merge-on-green
Copy link
Copy Markdown
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@busunkim96 busunkim96 merged commit 3edf9e5 into master Apr 9, 2020
@busunkim96 busunkim96 deleted the app-engine-py2-memorystore branch April 9, 2020 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants