Add GAE billing tests + fix region tags#2774
Merged
Conversation
kurtisvg
approved these changes
Feb 5, 2020
andrewsg
approved these changes
Feb 5, 2020
added 10 commits
February 5, 2020 11:15
…dPlatform/python-docs-samples into gae-billing-tests-2772
Author
|
Chatted offline with @kurtisvg - since GCF only supports Python 3.7, we can disable |
grant
approved these changes
Feb 5, 2020
tmatsuo
reviewed
May 18, 2020
| # Skip unsupported Python versions for Cloud Functions | ||
| # (Some GCF samples' dependencies don't support them) | ||
| if [[ "$file" == "functions/"* ]]; then | ||
| PYTHON_VERSION="$(python --version 2>&1)" |
Contributor
There was a problem hiding this comment.
FYI, this code is completely wrong.
This code checks the default Python version, rather than Python version in the nox session.
This resulted in disabling all the tests under functions directory. #3767 removed this code block then our tests started to fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2772