Skip to content

Adding environment port variable #2748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leahecole merged 2 commits into from
Jan 27, 2020
+7 −7
Merged

Adding environment port variable #2748

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
427d155
Adding environment port variable
dinagraves Jan 23, 2020
d35b049
Merge branch 'master' into cloud-run-local
leahecole Jan 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions run/hello-broken/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ docker build --tag hello-broken:python .
## Run Locally

```
docker run --rm -p 9090:8080 hello-broken:python
docker run --rm -p 9090:8080 -e PORT=8080 hello-broken:python
```

## Test
Expand All @@ -44,4 +44,4 @@ gcloud run deploy hello-broken \
```


For more details on how to work with this sample read the [Python Cloud Run Samples README](https://github.com/GoogleCloudPlatform/python-docs-samples/tree/master/run)
For more details on how to work with this sample read the [Python Cloud Run Samples README](https://github.com/GoogleCloudPlatform/python-docs-samples/tree/master/run)
2 changes: 1 addition & 1 deletion run/image-processing/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ docker build --tag pubsub-tutorial:python .
## Run Locally

```
docker run --rm -p 9090:8080 pubsub-tutorial:python
docker run --rm -p 9090:8080 -e PORT=8080 pubsub-tutorial:python
```

## Test
Expand Down
4 changes: 2 additions & 2 deletions run/logging-manual/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ docker build --tag logging-manual:python .
## Run Locally

```
docker run --rm -p 9090:8080 logging-manual:python
docker run --rm -p 9090:8080 -e PORT=8080 logging-manual:python
```

## Test
Expand Down Expand Up @@ -44,4 +44,4 @@ gcloud beta run deploy logging-manual \

Read more about Cloud Run logging in the [Logging How-to Guide](http://cloud.google.com/run/docs/logging).

For more details on how to work with this sample read the [Python Cloud Run Samples README](https://github.com/GoogleCloudPlatform/python-docs-samples/tree/master/run)
For more details on how to work with this sample read the [Python Cloud Run Samples README](https://github.com/GoogleCloudPlatform/python-docs-samples/tree/master/run)
2 changes: 1 addition & 1 deletion run/pubsub/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ docker build --tag pubsub-tutorial:python .
## Run Locally

```
docker run --rm -p 9090:8080 pubsub-tutorial:python
docker run --rm -p 9090:8080 -e PORT=8080 pubsub-tutorial:python
```

## Test
Expand Down
2 changes: 1 addition & 1 deletion run/system-package/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ docker build --tag graphviz:python .
## Run Locally

```
docker run --rm -p 9090:8080 graphviz:python
docker run --rm -p 9090:8080 -e PORT=8080 graphviz:python
```

## Test
Expand Down