Skip to content

Decode base64.b64decode output as string for Python 3 compatibility.#1910

Merged
engelke merged 4 commits into
GoogleCloudPlatform:masterfrom
wwlian:master
Jan 25, 2019
Merged

Decode base64.b64decode output as string for Python 3 compatibility.#1910
engelke merged 4 commits into
GoogleCloudPlatform:masterfrom
wwlian:master

Conversation

@wwlian

@wwlian wwlian commented Dec 6, 2018

Copy link
Copy Markdown
Contributor

Closes #1895

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 6, 2018

@engelke engelke left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmcarp

jmcarp commented Dec 8, 2018

Copy link
Copy Markdown
Contributor

It looks like we're decoding json here, so do we need to use ast.literal_eval? I switched to json.loads in #1919, and it's working fine for me on python 2 and 3.

@engelke

engelke commented Jan 25, 2019

Copy link
Copy Markdown
Contributor

Kokoro tests are not running automatically, and are not passing, for reasons unrelated to this PR.

@engelke engelke merged commit b393619 into GoogleCloudPlatform:master Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants