chore(dataflow/gemma): update dependencies and format code#14321
chore(dataflow/gemma): update dependencies and format code#14321XrossFox wants to merge 1 commit into
Conversation
- Update tensorflow base image to 2.20.0-gpu and beam sdk to 3.11/2.74.0 - Update apache_beam, keras, keras_nlp, and protobuf dependencies - Update test dependencies including google-cloud-aiplatform, storage, and pytest - Format custom_model_gemma.py and e2e_test.py - Update ignored python versions in noxfile_config.py
There was a problem hiding this comment.
Code Review
This pull request updates the Gemma Dataflow sample by changing the Python SDK base image from version 3.14 to 3.11, upgrading TensorFlow to 2.20.0, and updating Apache Beam to 2.74.0. It also upgrades several runtime and test dependencies and applies code formatting across multiple files. Feedback on the changes suggests updating noxfile_config.py to ignore Python versions 3.12, 3.13, and 3.14 to align with the target Python 3.11 environment and prevent redundant test runs.
| "PYTHONPATH": ".." | ||
| }, | ||
| # Note: Docker-based sample, testing only against version specified in Dockerfile (3.11) | ||
| "ignored_versions": ["3.8", "3.9", "3.10"], |
There was a problem hiding this comment.
The comment on line 21 states that this is a Docker-based sample, testing only against the Python version specified in the Dockerfile (3.11). However, the ignored_versions list only ignores 3.8, 3.9, and 3.10, which means tests will still run on 3.12, 3.13, and 3.14. To align with the comment and avoid redundant test runs on other Python versions, please ignore all versions except 3.11.
| "ignored_versions": ["3.8", "3.9", "3.10"], | |
| "ignored_versions": ["3.8", "3.9", "3.10", "3.12", "3.13", "3.14"], |
References
- When upgrading test dependencies that require a minimum Python version, ensure that test configurations (e.g., ignored_versions in noxfile_config.py) are updated to ignore incompatible Python versions.
Description
Fixes b/521868825
Checklist
Testing
Compliance & Style
Post-Approval Actions