Update dependency cloud-composer-dag-test-utils to v1#14004
Update dependency cloud-composer-dag-test-utils to v1#14004renovate-bot wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the cloud-composer-dag-test-utils dependency to version 1.0.0. The review identifies that this version is incompatible with the Airflow 1.x samples in the directory, as it requires Airflow 2.x, and recommends reverting the change to maintain compatibility.
| @@ -1,2 +1,2 @@ | |||
| pytest==8.2.0 | |||
| cloud-composer-dag-test-utils==0.0.1 | |||
| cloud-composer-dag-test-utils==1.0.0 | |||
There was a problem hiding this comment.
This update introduces a dependency on Airflow 2.x, which is incompatible with the Airflow 1.x samples in this directory. The setup.py for cloud-composer-dag-test-utils==1.0.0 specifies install_requires=["apache-airflow[google] >= 2.0.0, < 3.0.0"]. However, the code in composer/airflow_1_samples/ is intended for Airflow 1.x, as indicated by the directory name and contents like conftest.py. This version bump will break the tests for the Airflow 1 samples. This change should be reverted.
cloud-composer-dag-test-utils==0.0.1
This PR contains the following updates:
==0.0.1→==1.0.0Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Never, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.