Skip to content

chore(endpoints): add region tag endpoints_secret_1#12989

Merged
alarconesparza merged 1 commit into
GoogleCloudPlatform:mainfrom
alarconesparza:alarconesparza-chore-migrate-region-tag-347825630
Dec 13, 2024
Merged

chore(endpoints): add region tag endpoints_secret_1#12989
alarconesparza merged 1 commit into
GoogleCloudPlatform:mainfrom
alarconesparza:alarconesparza-chore-migrate-region-tag-347825630

Conversation

@alarconesparza
Copy link
Copy Markdown
Contributor

@alarconesparza alarconesparza commented Dec 11, 2024

Description

Fixes
Internal b/347825630

Checklist

Copy link
Copy Markdown

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @alarconesparza and reviewers,

I'm currently reviewing this pull request and will post my detailed review in a few minutes. In the meantime, here's a quick summary to help everyone get up to speed:

This PR, chore(endpoints): add region tag endpoints_secret_1, focuses on adding a region tag to the endpoints_secret_1 section within the k8s-grpc-bookstore.yaml file. The change involves inserting a new region tag around an existing secret definition. The intent, based on the PR description and the internal bug reference (b/347825630), appears to be to improve the clarity and organization of the Kubernetes configuration file related to secrets management. The specific change adds # [START endpoints_secret_1] and # [END endpoints_secret_1] comments around lines 46-51 in endpoints/kubernetes/k8s-grpc-bookstore.yaml to better delineate a specific section of the Kubernetes configuration file.

The changes are limited to the addition of these comment lines, which should not affect the functionality of the Kubernetes deployment itself. The PR also appears to follow the project's guidelines and includes the necessary checklist items.


A little haiku to brighten your day:

Secrets in the YAML,
Region tags add clarity's gleam,
Code flows smoothly on.

@product-auto-label product-auto-label Bot added api: endpoints Issues related to the Cloud Endpoints API. samples Issues that are directly related to samples. labels Dec 11, 2024
Copy link
Copy Markdown

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request adds a new region tag endpoints_secret_1 which encompasses the existing secret-1 tag in the k8s-grpc-bookstore.yaml file. It's good practice to encapsulate related sections of code with region tags, but it's important to make sure the region tags are placed correctly and that the documentation reflects the changes. I noticed a few minor issues that should be addressed before merging this pull request.

Comment thread endpoints/kubernetes/k8s-grpc-bookstore.yaml
Comment thread endpoints/kubernetes/k8s-grpc-bookstore.yaml
Comment thread endpoints/kubernetes/k8s-grpc-bookstore.yaml
@alarconesparza alarconesparza marked this pull request as ready for review December 13, 2024 16:12
@alarconesparza alarconesparza requested review from a team as code owners December 13, 2024 16:12
@snippet-bot
Copy link
Copy Markdown

snippet-bot Bot commented Dec 13, 2024

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@alarconesparza alarconesparza merged commit 628c16d into GoogleCloudPlatform:main Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: endpoints Issues related to the Cloud Endpoints API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants