Skip to content

Update supervised_advanced_example.py to support byosa and cmek#12978

Merged
iennae merged 2 commits into
GoogleCloudPlatform:mainfrom
liulehui:patch-2
Dec 10, 2024
Merged

Update supervised_advanced_example.py to support byosa and cmek#12978
iennae merged 2 commits into
GoogleCloudPlatform:mainfrom
liulehui:patch-2

Conversation

@liulehui

@liulehui liulehui commented Dec 9, 2024

Copy link
Copy Markdown
Contributor

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

@liulehui liulehui requested review from a team as code owners December 9, 2024 19:00
@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label Dec 9, 2024

# TODO(developer): If you need to use CMEK, Update and un-comment the below line
# vertexai.init(encryption_spec_key_name="your-kms-key")

@iennae iennae Dec 10, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the PR but, what do you think of something like the following to provide a little more context to folks who are seeing these samples and might not know what BYOSA or CMEK are?

# Initialize Vertex AI with your service account for BYOSA (Bring Your Own Service Account).
# Uncomment the following and replace "your-service-account" 
# vertexai.init(service_account="your-service-account")


# Initialize Vertex AI with your CMEK (Customer-Managed Encryption Key).
# Un-comment the following line and replace "your-kms-key" 
# vertexai.init(encryption_spec_key_name="your-kms-key") 

@iennae iennae merged commit 3455111 into GoogleCloudPlatform:main Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants