Skip to content

feat: Batch create job with NFS sample#12088

Merged
Thoughtseize1 merged 20 commits into
mainfrom
create-job-with-nfs
Aug 5, 2024
Merged

feat: Batch create job with NFS sample#12088
Thoughtseize1 merged 20 commits into
mainfrom
create-job-with-nfs

Conversation

@Thoughtseize1

@Thoughtseize1 Thoughtseize1 commented Jul 31, 2024

Copy link
Copy Markdown
Contributor

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

@product-auto-label product-auto-label Bot added samples Issues that are directly related to samples. api: batch Issues related to the Batch API. labels Jul 31, 2024
@Thoughtseize1 Thoughtseize1 added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 31, 2024
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 31, 2024
@Thoughtseize1 Thoughtseize1 added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 31, 2024
Comment thread batch/create/create_with_nfs.py Outdated
Comment on lines +55 to +56
f"echo Hello world from task ${{BATCH_TASK_INDEX}}. >> {mount_path}/output_task_${{"
f"BATCH_TASK_INDEX}}.txt"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use {{double}} brackets. Use a single {set} and it should work I think.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed all of the brackets to see how it worked without them and hardcoded a location similar to yours in Filestore us-central1.
And I also use only 1 task, like the example you sent me.
Gob still ends up with FAILED status.

Could you please verify that the test environment can access Filestore's IP address?

@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 1, 2024
@m-strzelczyk m-strzelczyk marked this pull request as ready for review August 3, 2024 10:46
@m-strzelczyk m-strzelczyk requested review from a team as code owners August 3, 2024 10:46
@snippet-bot

snippet-bot Bot commented Aug 3, 2024

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@Thoughtseize1 Thoughtseize1 merged commit 196935e into main Aug 5, 2024
@Thoughtseize1 Thoughtseize1 deleted the create-job-with-nfs branch August 5, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: batch Issues related to the Batch API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants