Skip to content

Add Samples for Vertex AI RAG#11460

Merged
kweinmeister merged 22 commits into
mainfrom
rag
Apr 22, 2024
Merged

Add Samples for Vertex AI RAG#11460
kweinmeister merged 22 commits into
mainfrom
rag

Conversation

@holtskinner
Copy link
Copy Markdown
Contributor

Needed for cl/620709657

@holtskinner holtskinner requested review from a team as code owners April 16, 2024 17:29
@snippet-bot
Copy link
Copy Markdown

snippet-bot Bot commented Apr 16, 2024

Here is the summary of changes.

You are about to add 13 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label Apr 16, 2024
Comment thread generative_ai/rag.py Outdated
Copy link
Copy Markdown
Contributor

@yinghsienwu yinghsienwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR

Comment thread generative_ai/rag.py Outdated
Comment thread generative_ai/rag.py Outdated
Comment thread generative_ai/rag.py Outdated
Comment thread generative_ai/rag.py
Comment thread generative_ai/requirements.txt
@holtskinner holtskinner added the api: vertex-ai Issues related to the Vertex AI API. label Apr 19, 2024
@qizzzh
Copy link
Copy Markdown

qizzzh commented Apr 19, 2024

Thanks Holt! small nit: vertexai.init has some overhead. Maybe we can have some comment saying it only needs to be called once per session or so.

@holtskinner
Copy link
Copy Markdown
Contributor Author

@qizzzh

The code samples team is trying to simplify our samples and reduce boilerplate where needed. The other Gemini samples don't include anything about doing the init once per session, should they be changed as well?

@qizzzh
Copy link
Copy Markdown

qizzzh commented Apr 19, 2024

I think some comments may be sufficient for now. It's not difficult for developers to figure it out.

@holtskinner
Copy link
Copy Markdown
Contributor Author

Note: I've tested the samples locally with the dev SDK and an allowlisted project, and they are all passing.

@kweinmeister kweinmeister merged commit 28bb55e into main Apr 22, 2024
@kweinmeister kweinmeister deleted the rag branch April 22, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: vertex-ai Issues related to the Vertex AI API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants