Node 6: add Firebase snippets#697
Conversation
|
@mogar1980 FYI |
fhinkel
left a comment
There was a problem hiding this comment.
LGTM, but maybe a firebase person can have a look?
|
cc @samtstern (Firebase DPE) |
|
|
||
| // [START functions_firebase_auth] | ||
| /** | ||
| * Triggered by a change to a Firebase Auth user object. |
There was a problem hiding this comment.
I think we only have triggers for user creation and deletion right now, not on any change to the user object.
|
|
||
| // [START functions_firebase_analytics] | ||
| /** | ||
| * Triggered by a Firebase Mobile Analytics log event. |
There was a problem hiding this comment.
We call it "Google Analytics for Firebase"
|
Two small comments but LGTM (assuming they actually work, I did not take the time to deploy them) |
Codecov Report
@@ Coverage Diff @@
## master #697 +/- ##
=======================================
Coverage 55.17% 55.17%
=======================================
Files 1 1
Lines 58 58
=======================================
Hits 32 32
Misses 26 26Continue to review full report at Codecov.
|
|
Removed broken Analytics sample; merging the rest when tests pass. |
Do not merge until we figure out the following: