Skip to content

chore: update uuid to ^11.1.1 in first chunk of packages#4353

Open
angelcaamal wants to merge 5 commits into
mainfrom
fix/uuid-update-chunk-1
Open

chore: update uuid to ^11.1.1 in first chunk of packages#4353
angelcaamal wants to merge 5 commits into
mainfrom
fix/uuid-update-chunk-1

Conversation

@angelcaamal

@angelcaamal angelcaamal commented Jun 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@product-auto-label product-auto-label Bot added samples Issues that are directly related to samples. api: aiplatform Issues related to the AI Platform API. api: appengine Issues related to the App Engine Admin API API. api: auth api: automl Issues related to the AutoML API. api: cloudasset Issues related to the Cloud Asset Inventory API. api: compute Issues related to the Compute Engine API. api: language Issues related to the Cloud Natural Language API API. api: tasks Issues related to the Tasks API API. asset: pattern DEE Asset tagging - Pattern. labels Jun 22, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jun 22, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the uuid dependency to version ^11.1.1 across multiple package.json files. The review feedback correctly identifies that uuid v11 requires Node.js >= 18.0.0, which breaks compatibility for directories targeting older Node.js versions (such as flexible_nodejs16_and_earlier and asset/snippets). Additionally, it is recommended to update corresponding @types/uuid dependencies to prevent type mismatches.

Comment thread appengine/storage/flexible_nodejs16_and_earlier/package.json
Comment thread asset/snippets/package.json
Comment thread appengine/storage/flexible/package.json
@angelcaamal angelcaamal marked this pull request as ready for review June 22, 2026 22:30
@angelcaamal angelcaamal requested review from a team as code owners June 22, 2026 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grayside grayside grayside approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: aiplatform Issues related to the AI Platform API. api: appengine Issues related to the App Engine Admin API API. api: auth api: automl Issues related to the AutoML API. api: cloudasset Issues related to the Cloud Asset Inventory API. api: compute Issues related to the Compute Engine API. api: language Issues related to the Cloud Natural Language API API. api: tasks Issues related to the Tasks API API. asset: pattern DEE Asset tagging - Pattern. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@angelcaamal @grayside