fix(dlp): resolve CommonJS compatibility issues and stabilize test #4350
Open
angelcaamal wants to merge 3 commits into
Open
fix(dlp): resolve CommonJS compatibility issues and stabilize test #4350angelcaamal wants to merge 3 commits into
angelcaamal wants to merge 3 commits into
Conversation
amcolin
requested changes
Jun 19, 2026
amcolin
left a comment
Contributor
There was a problem hiding this comment.
Downgrading the dependency doesn't seem like the best practice in this situation. Could we explore the possibility of implementing dynamic imports instead?
// Remove this line
// const {assert} = require('chai');
let assert;
// And on the before
before(async () => {
// To bypass the ERR_REQUIRE_ESM restriction
const chai = await import('chai');
assert = chai.assert;
projectId = await client.getProjectId();
});
Contributor
Author
|
@amcolin Thanks for your feedback. While that possibility exists, the way libraries are imported across all samples in this repository is using require() (CommonJS module system); we currently do not have support for ESM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes runtime errors in the DLP samples caused by dependency versions that exclusively support ESM, which are incompatible with the existing CommonJS architecture of these samples.
Changes included:
inspectWithCustomHotwords.js): Updated the hardcoded mock SSN from222-22-2222to458-90-3124. The DLP API's ML model identifies repetitive/obvious test data asVERY_UNLIKELY. Since the sample is configured withminLikelihood: POSSIBLE, the test was failing to detect findings. Using a realistic sequence ensures the API returns the expected results in the test suite.Fixes Internal: b/525822800
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test(see Testing)npm run lint(see Style)GoogleCloudPlatform/nodejs-docs-samples. Not a fork.