fix(test): resolve linting issues in translate_batch_translate_text.test.js#4345
Open
angelcaamal wants to merge 4 commits into
Open
fix(test): resolve linting issues in translate_batch_translate_text.test.js#4345angelcaamal wants to merge 4 commits into
angelcaamal wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a non-standard parenthesized grouping around Mocha hooks and tests in translate_batch_translate_text.test.js. The review feedback recommends reverting this change to restore standard Mocha test structure and improve readability.
Contributor
Author
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request corrects syntax and formatting in the batch translation test file, replacing incorrect comma separators with semicolons and fixing block indentation. Feedback suggests simplifying the cleanup logic in the after hook by using the built-in bucket.deleteFiles(options) method instead of manually fetching and deleting files individually.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses linting and formatting issues identified in translate_batch_translate_text.test.js.
Changes:
Fixes Internal: b/524742483
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test(see Testing)npm run lint(see Style)GoogleCloudPlatform/nodejs-docs-samples. Not a fork.