Repository navigation
feat(run): add Cloud Run + Filestore sample - #3288
Merged
Merged
Conversation
rogerthatdev
marked this pull request as ready for review
June 27, 2023 19:43
rogerthatdev
marked this pull request as ready for review
July 17, 2023 19:35
averikitsch
reviewed
Jul 17, 2023
averikitsch
reviewed
Jul 17, 2023
averikitsch
reviewed
Jul 17, 2023
averikitsch
reviewed
Jul 17, 2023
averikitsch
reviewed
Jul 17, 2023
| console.log(`Listening on port ${port}`); | ||
| }); | ||
|
|
||
| app.get(mntDir, async (req, res) => { |
Contributor
There was a problem hiding this comment.
This doesn't add the "back" button to get back to the mount directory index.
Contributor
Author
There was a problem hiding this comment.
This sample can't add the back button because it's returning the actual file which is a plain-text .txt without HTML
Contributor
There was a problem hiding this comment.
The canonical does this differently. Do you have a reason to break from the canonical?
Contributor
Author
GCS Fuse files to be added in separate PR |
averikitsch
approved these changes
Jul 24, 2023
Contributor
Author
|
fixes #3019 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request will add a nodejs sample for deploying Cloud Run with a connected filestore.
To manually test full deployment to Cloud see Using Filestore with Cloud Run tutorial
Upon deployment:
/will generate a test file to the mounted filestore./will show file contents./filesystemwill present the files on the filesystem viaserve-indexChecklist
npm test(see Testing)npm run lint(see Style)