Skip to content

build: perform 404 scanning on docs#2305

Merged
JustinBeckwith merged 2 commits into
masterfrom
docsy
Aug 3, 2021
Merged

build: perform 404 scanning on docs#2305
JustinBeckwith merged 2 commits into
masterfrom
docsy

Conversation

@JustinBeckwith
Copy link
Copy Markdown
Contributor

@JustinBeckwith JustinBeckwith commented Aug 3, 2021

Fixes #2258 and prevents it moving forward.

@JustinBeckwith JustinBeckwith requested review from a team, ace-n and engelke as code owners August 3, 2021 18:35
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 3, 2021
@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label Aug 3, 2021
Copy link
Copy Markdown
Contributor

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@ace-n ace-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I see a lot of whitespace changes. (They're fine to keep, though I presume they're automated? 🙁 )

@JustinBeckwith
Copy link
Copy Markdown
Contributor Author

Yeah just editor settings that auto-strip whitespace

@JustinBeckwith JustinBeckwith merged commit 8f2378b into master Aug 3, 2021
@JustinBeckwith JustinBeckwith deleted the docsy branch August 3, 2021 21:22
noerog pushed a commit that referenced this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken links to codelab in README.md

4 participants