Skip to content

fix(samples): auth samples used top level await#1871

Merged
fhinkel merged 1 commit into
masterfrom
new-sampleify
Jun 12, 2020
Merged

fix(samples): auth samples used top level await#1871
fhinkel merged 1 commit into
masterfrom
new-sampleify

Conversation

@bcoe
Copy link
Copy Markdown

@bcoe bcoe commented Jun 12, 2020

we were following the old sample format, resulting in code that breaks when copy pasted.

@bcoe bcoe requested a review from fhinkel as a code owner June 12, 2020 00:51
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 12, 2020
Copy link
Copy Markdown
Contributor

@fhinkel fhinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@fhinkel fhinkel merged commit 1fdfddd into master Jun 12, 2020
@fhinkel fhinkel deleted the new-sampleify branch November 5, 2020 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants