Skip to content

refactor(jobs): convert ava tests to mocha#1147

Merged
fhinkel merged 17 commits into
GoogleCloudPlatform:masterfrom
nareshqlogic:jobs-ava-to-mocha
Mar 7, 2019
Merged

refactor(jobs): convert ava tests to mocha#1147
fhinkel merged 17 commits into
GoogleCloudPlatform:masterfrom
nareshqlogic:jobs-ava-to-mocha

Conversation

@nareshqlogic
Copy link
Copy Markdown
Contributor

@nareshqlogic nareshqlogic commented Feb 15, 2019

Tracking issue: Convert tests from ava to mocha #1080 (it's a good idea to open an issue first for discussion)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 15, 2019
@nareshqlogic nareshqlogic added the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 20, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 20, 2019
@nareshqlogic nareshqlogic added the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 21, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 21, 2019
@nareshqlogic nareshqlogic added the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 25, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 25, 2019
@fhinkel fhinkel added automerge Merge the pull request once unit tests and other checks pass. kokoro:run Add this label to force Kokoro to re-run the tests. labels Feb 28, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 28, 2019
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 1, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 1, 2019
@fhinkel fhinkel added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 2, 2019
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 2, 2019
fhinkel
fhinkel requested changes Mar 2, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@fhinkel fhinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter is failing

@fhinkel fhinkel removed automerge Merge the pull request once unit tests and other checks pass. labels Mar 2, 2019
@nareshqlogic nareshqlogic added the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 6, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 6, 2019
@nareshqlogic nareshqlogic added the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 7, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 7, 2019
@nareshqlogic nareshqlogic requested a review from fhinkel March 7, 2019 12:52
@fhinkel fhinkel merged commit b805fef into GoogleCloudPlatform:master Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fhinkel fhinkel fhinkel approved these changes

@JustinBeckwith JustinBeckwith Awaiting requested review from JustinBeckwith

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nareshqlogic @fhinkel @googlebot @kokoro-team