Skip to content

resourceIdentity: set MutableIdentity to true by default#17030

Merged
BBBmau merged 1 commit intoGoogleCloudPlatform:mainfrom
BBBmau:default-mutable-identity-true
Apr 9, 2026
Merged

resourceIdentity: set MutableIdentity to true by default#17030
BBBmau merged 1 commit intoGoogleCloudPlatform:mainfrom
BBBmau:default-mutable-identity-true

Conversation

@BBBmau
Copy link
Copy Markdown
Collaborator

@BBBmau BBBmau commented Apr 8, 2026

Several identity values are mutable, allowing users to change them without needing to destroy/recreate them.

Below is a list of resources that currently have mutable identity values. This PR introudces MutableIdentity: true by default. A follow-up PR will be created to explicitly set MutableIdentity to true based on resourceMetadata.yaml

google_app_engine_firewall_rule -> priority
google_vertex_ai_feature_group  -> name
google_data_pipeline_pipeline -> region
google_dialogflow_environment -> location
google_network_security_backend_authentication_config -> location
google_network_security_client_tls_policy -> location
google_network_security_gateway_security_policy -> location
google_network_security_server_tls_policy -> location
google_network_security_tls_inspection_policy -> location
google_network_services_gateway -> location
google_pubsub_lite_reservation  -> region
google_pubsub_lite_subscription -> zone
google_pubsub_lite_topic  -> zone

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

@BBBmau BBBmau requested a review from rileykarson April 8, 2026 22:52
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented Apr 8, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 694 files changed, 2082 insertions(+))
google-beta provider: Diff ( 770 files changed, 2310 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented Apr 9, 2026

Tests analytics

Total tests: 5573
Passed tests: 5069
Skipped tests: 490
Affected tests: 14

Click here to see the affected service packages
  • apihub
  • containeranalysis
  • gkeonprem
  • serviceusage
  • vectorsearch
  • colab
  • dialogflow
  • gkehub
  • integrations
  • modelarmorglobal
  • oslogin
  • pubsublite
  • securitycentermanagement
  • dataprocgdc
  • storage
  • alloydb
  • bigqueryanalyticshub
  • blockchainnodeengine
  • dialogflowcx
  • orgpolicy
  • saasruntime
  • accesscontextmanager
  • cloudidentity
  • datastream
  • gkehub2
  • storagebatchoperations
  • certificatemanager
  • cloudbuild
  • firebaseextensions
  • managedkafka
  • sql
  • bigquerydatapolicyv2
  • bigquerydatatransfer
  • cloudrun
  • iamworkforcepool
  • vmwareengine
  • backupdr
  • networkmanagement
  • storageinsights
  • workstations
  • containerattached
  • datalossprevention
  • edgecontainer
  • firebase
  • kms
  • looker
  • osconfig
  • servicenetworking
  • apigee
  • datafusion
  • edgenetwork
  • firebaseailogic
  • resourcemanager
  • siteverification
  • sourcerepo
  • biglake
  • gkebackup
  • iam3
  • transcoder
  • vertexai
  • cloudscheduler
  • contactcenterinsights
  • tpuv2
  • bigqueryreservation
  • cloudsecuritycompliance
  • compute
  • netapp
  • artifactregistry
  • bigquerydatapolicy
  • clouddeploy
  • eventarc
  • filestore
  • dataplex
  • cloudquotas
  • dataproc
  • dns
  • documentaiwarehouse
  • resourcemanager3
  • storagetransfer
  • binaryauthorization
  • cloudrunv2
  • iam2
  • monitoring
  • privateca
  • securityscanner
  • dataprocmetastore
  • documentai
  • healthcare
  • secretmanager
  • workflows
  • firebaseapphosting
  • securesourcemanager
  • biglakeiceberg
  • composer
  • pubsub
  • billing
  • discoveryengine
  • iap
  • logging
  • lustre
  • memorystore
  • securitycenterv2
  • datapipeline
  • appengine
  • cloudasset
  • deploymentmanager
  • firebasestorage
  • hypercomputecluster
  • redis
  • activedirectory
  • corebilling
  • databasemigrationservice
  • firebasehosting
  • firestore
  • gemini
  • networkconnectivity
  • beyondcorp
  • cloudbuildv2
  • clouddomains
  • firebasedataconnect
  • memcache
  • securityposture
  • developerconnect
  • iambeta
  • migrationcenter
  • parametermanagerregional
  • privilegedaccessmanager
  • accessapproval
  • cloudids
  • essentialcontacts
  • firebaseappcheck
  • oracledatabase
  • apphub
  • dataform
  • identityplatform
  • parametermanager
  • secretmanagerregional
  • securitycenter
  • storagecontrol
  • bigqueryconnection
  • cloudtasks
  • notebooks
  • parallelstore
  • vpcaccess
  • networkconnectivityv1
  • networksecurity
  • osconfigv2
  • apigateway
  • bigquery
  • ces
  • cloudfunctions2
  • integrationconnectors
  • networkservices
  • tags
  • datacatalog
  • firebasedatabase
  • modelarmor
  • observability
  • spanner
  • workbench
  • bigtable
  • chronicle
  • mlengine

Action taken

Found 14 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample
  • TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample
  • TestAccArtifactRegistryRepository_artifactRegistryRepositoryCleanupExample
  • TestAccArtifactRegistryRepository_cleanup
  • TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
  • TestAccCloudRunService_cloudRunServiceGpuExample
  • TestAccDataSourceGoogleBackupDRManagementServer_basic
  • TestAccDataformConfig_dataformConfigWithKmsKeyExample
  • TestAccDataformConfig_update
  • TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccProjectIamMemberRemove_memberInMultipleBindings
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented Apr 9, 2026

🟢 Tests passed during RECORDING mode:
TestAccDataformConfig_dataformConfigWithKmsKeyExample [Debug log]
TestAccProjectIamMemberRemove_memberInMultipleBindings [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccProjectIamMemberRemove_memberInMultipleBindings [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample [Error message] [Debug log]
TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample [Error message] [Debug log]
TestAccArtifactRegistryRepository_artifactRegistryRepositoryCleanupExample [Error message] [Debug log]
TestAccArtifactRegistryRepository_cleanup [Error message] [Debug log]
TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample [Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceGpuExample [Error message] [Debug log]
TestAccDataSourceGoogleBackupDRManagementServer_basic [Error message] [Debug log]
TestAccDataformConfig_update [Error message] [Debug log]
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample [Error message] [Debug log]
TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample [Error message] [Debug log]
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample [Error message] [Debug log]
TestAccPubsubSubscription_pubsubSubscriptionTagsExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@BBBmau BBBmau added this pull request to the merge queue Apr 9, 2026
Merged via the queue into GoogleCloudPlatform:main with commit b642925 Apr 9, 2026
22 of 23 checks passed
@BBBmau BBBmau deleted the default-mutable-identity-true branch April 9, 2026 02:19
This was referenced Apr 9, 2026
Merged
Merged
BBBmau added a commit to BBBmau/magic-modules that referenced this pull request Apr 10, 2026
@BBBmau
resourceIdentity: set MutableIdentity to true by default (Googl…
4066157 
…eCloudPlatform#17030)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rileykarson rileykarson rileykarson approved these changes

Assignees

No one assigned

Labels

service/terraform

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BBBmau @modular-magician @rileykarson