Skip to content

Fix IsSelfLink hostname validation #17018

Merged
malhotrasagar2212 merged 4 commits intoGoogleCloudPlatform:mainfrom
malhotrasagar2212:hostname_vulnerability_fix
Apr 14, 2026
Merged

Fix IsSelfLink hostname validation #17018
malhotrasagar2212 merged 4 commits intoGoogleCloudPlatform:mainfrom
malhotrasagar2212:hostname_vulnerability_fix

Conversation

@malhotrasagar2212
Copy link
Copy Markdown
Collaborator

@malhotrasagar2212 malhotrasagar2212 commented Apr 8, 2026 •
edited
Loading

This PR fixes a security vulnerability in IsSelfLink caused by an incomplete, regex-based hostname validation.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented Apr 8, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 16 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 1 file changed, 16 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented Apr 8, 2026

Tests analytics

Total tests: 6267
Passed tests: 5608
Skipped tests: 645
Affected tests: 14

Click here to see the affected service packages

All service packages are affected

Action taken

Found 14 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample
  • TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample
  • TestAccArtifactRegistryRepository_artifactRegistryRepositoryCleanupExample
  • TestAccArtifactRegistryRepository_cleanup
  • TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
  • TestAccCloudRunService_cloudRunServiceGpuExample
  • TestAccContainerCluster_withAutopilotResourceManagerTags
  • TestAccDataSourceGoogleBackupDRManagementServer_basic
  • TestAccDataformConfig_update
  • TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccProjectIamPolicy_invalidMembers
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented Apr 8, 2026

🟢 Tests passed during RECORDING mode:
TestAccDataformConfig_update [Debug log]
TestAccProjectIamPolicy_invalidMembers [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample [Error message] [Debug log]
TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample [Error message] [Debug log]
TestAccArtifactRegistryRepository_artifactRegistryRepositoryCleanupExample [Error message] [Debug log]
TestAccArtifactRegistryRepository_cleanup [Error message] [Debug log]
TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample [Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceGpuExample [Error message] [Debug log]
TestAccContainerCluster_withAutopilotResourceManagerTags [Error message] [Debug log]
TestAccDataSourceGoogleBackupDRManagementServer_basic [Error message] [Debug log]
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample [Error message] [Debug log]
TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample [Error message] [Debug log]
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample [Error message] [Debug log]
TestAccPubsubSubscription_pubsubSubscriptionTagsExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@malhotrasagar2212
Copy link
Copy Markdown
Collaborator Author

malhotrasagar2212 commented Apr 9, 2026

/gcbrun

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented Apr 9, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 16 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 1 file changed, 16 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented Apr 9, 2026

Tests analytics

Total tests: 6285
Passed tests: 5619
Skipped tests: 650
Affected tests: 16

Click here to see the affected service packages

All service packages are affected

Action taken

Found 16 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAccessContextManager__access_policy_iam_policy
  • TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample
  • TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample
  • TestAccArtifactRegistryRepository_artifactRegistryRepositoryCleanupExample
  • TestAccArtifactRegistryRepository_cleanup
  • TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
  • TestAccCloudRunService_cloudRunServiceGpuExample
  • TestAccContainerCluster_withAutopilotResourceManagerTags
  • TestAccDataSourceGoogleBackupDRManagementServer_basic
  • TestAccDataformConfig_update
  • TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccFolderIamPolicy_basic
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccProjectIamMemberRemove_memberInMultipleBindings
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented Apr 9, 2026

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager__access_level [Debug log]
TestAccAccessContextManager__access_level_condition [Debug log]
TestAccAccessContextManager__access_level_custom [Debug log]
TestAccAccessContextManager__access_level_full [Debug log]
TestAccAccessContextManager__access_levels [Debug log]
TestAccAccessContextManager__access_policy [Debug log]
TestAccAccessContextManager__data_source_access_policy_basic [Debug log]
TestAccAccessContextManager__service_perimeter [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_resource [Debug log]
TestAccAccessContextManager__service_perimeter_ingress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_resource [Debug log]
TestAccAccessContextManager__service_perimeter_update [Debug log]
TestAccDataformConfig_update [Debug log]
TestAccFolderIamPolicy_basic [Debug log]
TestAccProjectIamMemberRemove_memberInMultipleBindings [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccProjectIamMemberRemove_memberInMultipleBindings [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager__access_policy_iam_binding [Error message] [Debug log]
TestAccAccessContextManager__access_policy_iam_member [Error message] [Debug log]
TestAccAccessContextManager__access_policy_iam_policy [Error message] [Debug log]
TestAccAccessContextManager__access_policy_scoped [Error message] [Debug log]
TestAccAccessContextManager__authorized_orgs_desc [Error message] [Debug log]
TestAccAccessContextManager__data_source_access_policy_scoped [Error message] [Debug log]
TestAccAccessContextManager__gcp_user_access_binding [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_egress_policy [Error message] [Debug log]
TestAccAccessContextManager__service_perimeters [Error message] [Debug log]
TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample [Error message] [Debug log]
TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample [Error message] [Debug log]
TestAccArtifactRegistryRepository_artifactRegistryRepositoryCleanupExample [Error message] [Debug log]
TestAccArtifactRegistryRepository_cleanup [Error message] [Debug log]
TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample [Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceGpuExample [Error message] [Debug log]
TestAccContainerCluster_withAutopilotResourceManagerTags [Error message] [Debug log]
TestAccDataSourceGoogleBackupDRManagementServer_basic [Error message] [Debug log]
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample [Error message] [Debug log]
TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample [Error message] [Debug log]
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample [Error message] [Debug log]
TestAccPubsubSubscription_pubsubSubscriptionTagsExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented Apr 13, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 16 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 1 file changed, 16 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented Apr 13, 2026

Tests analytics

Total tests: 6294
Passed tests: 5629
Skipped tests: 651
Affected tests: 14

Click here to see the affected service packages

All service packages are affected

Action taken

Found 14 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAccessContextManager__access_policy_iam_policy
  • TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample
  • TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample
  • TestAccArtifactRegistryRepository_artifactRegistryRepositoryCleanupExample
  • TestAccArtifactRegistryRepository_cleanup
  • TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
  • TestAccCloudRunService_cloudRunServiceGpuExample
  • TestAccContainerCluster_withAutopilotResourceManagerTags
  • TestAccDataSourceGoogleBackupDRManagementServer_basic
  • TestAccDataformConfig_update
  • TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented Apr 13, 2026

🟢 Tests passed during RECORDING mode:
TestAccDataformConfig_update [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataformConfig_update [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager__access_level [Error message] [Debug log]
TestAccAccessContextManager__access_level_condition [Error message] [Debug log]
TestAccAccessContextManager__access_level_custom [Error message] [Debug log]
TestAccAccessContextManager__access_level_full [Error message] [Debug log]
TestAccAccessContextManager__access_levels [Error message] [Debug log]
TestAccAccessContextManager__access_policy [Error message] [Debug log]
TestAccAccessContextManager__access_policy_iam_binding [Error message] [Debug log]
TestAccAccessContextManager__access_policy_iam_member [Error message] [Debug log]
TestAccAccessContextManager__access_policy_iam_policy [Error message] [Debug log]
TestAccAccessContextManager__access_policy_scoped [Error message] [Debug log]
TestAccAccessContextManager__authorized_orgs_desc [Error message] [Debug log]
TestAccAccessContextManager__data_source_access_policy_basic [Error message] [Debug log]
TestAccAccessContextManager__data_source_access_policy_scoped [Error message] [Debug log]
TestAccAccessContextManager__gcp_user_access_binding [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_resource [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_egress_policy [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_ingress_policy [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_resource [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_update [Error message] [Debug log]
TestAccAccessContextManager__service_perimeters [Error message] [Debug log]
TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample [Error message] [Debug log]
TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample [Error message] [Debug log]
TestAccArtifactRegistryRepository_artifactRegistryRepositoryCleanupExample [Error message] [Debug log]
TestAccArtifactRegistryRepository_cleanup [Error message] [Debug log]
TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample [Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceGpuExample [Error message] [Debug log]
TestAccContainerCluster_withAutopilotResourceManagerTags [Error message] [Debug log]
TestAccDataSourceGoogleBackupDRManagementServer_basic [Error message] [Debug log]
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample [Error message] [Debug log]
TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample [Error message] [Debug log]
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample [Error message] [Debug log]
TestAccPubsubSubscription_pubsubSubscriptionTagsExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented Apr 13, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented Apr 13, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented Apr 13, 2026

Tests analytics

Total tests: 6294
Passed tests: 5627
Skipped tests: 651
Affected tests: 16

Click here to see the affected service packages

All service packages are affected

Action taken

Found 16 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAccessContextManager__access_policy_iam_policy
  • TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample
  • TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample
  • TestAccArtifactRegistryRepository_artifactRegistryRepositoryCleanupExample
  • TestAccArtifactRegistryRepository_cleanup
  • TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
  • TestAccCloudRunService_cloudRunServiceGpuExample
  • TestAccComputeRouterPeer_AddMd5AuthenticationKey
  • TestAccContainerCluster_withAutopilotResourceManagerTags
  • TestAccDataSourceGoogleBackupDRManagementServer_basic
  • TestAccDataformConfig_update
  • TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccProjectIamMemberRemove_memberInMultipleBindings
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented Apr 13, 2026

Tests analytics

Total tests: 6294
Passed tests: 5628
Skipped tests: 651
Affected tests: 15

Click here to see the affected service packages

All service packages are affected

Action taken

Found 15 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAccessContextManager__access_policy_iam_policy
  • TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample
  • TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample
  • TestAccArtifactRegistryRepository_artifactRegistryRepositoryCleanupExample
  • TestAccArtifactRegistryRepository_cleanup
  • TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
  • TestAccCloudRunService_cloudRunServiceGpuExample
  • TestAccContainerCluster_withAutopilotResourceManagerTags
  • TestAccDataSourceGoogleBackupDRManagementServer_basic
  • TestAccDataformConfig_update
  • TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccProjectIamMemberRemove_memberInMultipleBindings
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented Apr 13, 2026

🟢 Tests passed during RECORDING mode:
TestAccDataformConfig_update [Debug log]
TestAccProjectIamMemberRemove_memberInMultipleBindings [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager__access_level [Error message] [Debug log]
TestAccAccessContextManager__access_level_condition [Error message] [Debug log]
TestAccAccessContextManager__access_level_custom [Error message] [Debug log]
TestAccAccessContextManager__access_level_full [Error message] [Debug log]
TestAccAccessContextManager__access_levels [Error message] [Debug log]
TestAccAccessContextManager__access_policy [Error message] [Debug log]
TestAccAccessContextManager__access_policy_iam_binding [Error message] [Debug log]
TestAccAccessContextManager__access_policy_iam_member [Error message] [Debug log]
TestAccAccessContextManager__access_policy_iam_policy [Error message] [Debug log]
TestAccAccessContextManager__access_policy_scoped [Error message] [Debug log]
TestAccAccessContextManager__authorized_orgs_desc [Error message] [Debug log]
TestAccAccessContextManager__data_source_access_policy_basic [Error message] [Debug log]
TestAccAccessContextManager__data_source_access_policy_scoped [Error message] [Debug log]
TestAccAccessContextManager__gcp_user_access_binding [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_resource [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_egress_policy [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_ingress_policy [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_resource [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_update [Error message] [Debug log]
TestAccAccessContextManager__service_perimeters [Error message] [Debug log]
TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample [Error message] [Debug log]
TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample [Error message] [Debug log]
TestAccArtifactRegistryRepository_artifactRegistryRepositoryCleanupExample [Error message] [Debug log]
TestAccArtifactRegistryRepository_cleanup [Error message] [Debug log]
TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample [Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceGpuExample [Error message] [Debug log]
TestAccContainerCluster_withAutopilotResourceManagerTags [Error message] [Debug log]
TestAccDataSourceGoogleBackupDRManagementServer_basic [Error message] [Debug log]
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample [Error message] [Debug log]
TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample [Error message] [Debug log]
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample [Error message] [Debug log]
TestAccPubsubSubscription_pubsubSubscriptionTagsExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented Apr 13, 2026

🟢 Tests passed during RECORDING mode:
TestAccComputeRouterPeer_AddMd5AuthenticationKey [Debug log]
TestAccDataformConfig_update [Debug log]
TestAccProjectIamMemberRemove_memberInMultipleBindings [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataformConfig_update [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager__access_level [Error message] [Debug log]
TestAccAccessContextManager__access_level_condition [Error message] [Debug log]
TestAccAccessContextManager__access_level_custom [Error message] [Debug log]
TestAccAccessContextManager__access_level_full [Error message] [Debug log]
TestAccAccessContextManager__access_levels [Error message] [Debug log]
TestAccAccessContextManager__access_policy [Error message] [Debug log]
TestAccAccessContextManager__access_policy_iam_binding [Error message] [Debug log]
TestAccAccessContextManager__access_policy_iam_member [Error message] [Debug log]
TestAccAccessContextManager__access_policy_iam_policy [Error message] [Debug log]
TestAccAccessContextManager__access_policy_scoped [Error message] [Debug log]
TestAccAccessContextManager__authorized_orgs_desc [Error message] [Debug log]
TestAccAccessContextManager__data_source_access_policy_basic [Error message] [Debug log]
TestAccAccessContextManager__data_source_access_policy_scoped [Error message] [Debug log]
TestAccAccessContextManager__gcp_user_access_binding [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_resource [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_egress_policy [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_ingress_policy [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_resource [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_update [Error message] [Debug log]
TestAccAccessContextManager__service_perimeters [Error message] [Debug log]
TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample [Error message] [Debug log]
TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample [Error message] [Debug log]
TestAccArtifactRegistryRepository_artifactRegistryRepositoryCleanupExample [Error message] [Debug log]
TestAccArtifactRegistryRepository_cleanup [Error message] [Debug log]
TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample [Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceGpuExample [Error message] [Debug log]
TestAccContainerCluster_withAutopilotResourceManagerTags [Error message] [Debug log]
TestAccDataSourceGoogleBackupDRManagementServer_basic [Error message] [Debug log]
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample [Error message] [Debug log]
TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample [Error message] [Debug log]
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample [Error message] [Debug log]
TestAccPubsubSubscription_pubsubSubscriptionTagsExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@malhotrasagar2212
Copy link
Copy Markdown
Collaborator Author

malhotrasagar2212 commented Apr 14, 2026

@BBBmau The failing tests doesn't appear to be due to the PR change. Please have a look.

BBBmau
BBBmau approved these changes Apr 14, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@BBBmau BBBmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The failing tests in VCR are unrelated to the change.

This change makes sense to do, it strictens the regex logic by explicitly asking for the literal ., before it was just any character.

@malhotrasagar2212 malhotrasagar2212 added this pull request to the merge queue Apr 14, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 915186b Apr 14, 2026
21 of 22 checks passed
@malhotrasagar2212 malhotrasagar2212 deleted the hostname_vulnerability_fix branch April 14, 2026 15:42
This was referenced Apr 14, 2026
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BBBmau BBBmau BBBmau approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@malhotrasagar2212 @modular-magician @BBBmau