Converted generated (same as registered, for now) products to use registry for setting up base paths#17011
Converted generated (same as registered, for now) products to use registry for setting up base paths#17011melinath wants to merge 15 commits intoGoogleCloudPlatform:mainfrom
Conversation
|
I'll want to also do some manual tests of the behavior tomorrow... that is, whether the list of products is the same & whether the replacements work as expected. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
e6672e1 to
5498595
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 6297 Click here to see the affected service packages
Action takenFound 14 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
|
VCR failures look unrelated to this change. |
|
Compared provider schema before/after this change with: Didn't see a diff (but feel free to double-check me.) |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 6311 Click here to see the affected service packages
Action takenFound 64 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
|
I think that I'll need to add a TGC-next registry (in a separate PR) before this one can be merged; the changes are too difficult to exclude / handle separately. So the order would be:
|
This is for compatibility with REP implementation - that probably needs a more permanent resolution but I'm leaving that for a separate PR
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 6329 Click here to see the affected service packages
Action takenFound 19 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
|
This PR is approved and has been waiting for merge for 1 week. Is it ready to merge? Use the label |
The core change here is using a map instead of a bunch of fields. For this iteration, I've stuck to just the currently-registered products (the list is/should be the same as generated products) to simplify things. I'll convert the remaining (handwritten) products separately (and register them along the way) so they can get more scrutiny.
I added the custom endpoint field name and the env var name to the product registration so that they're easy to access. This avoids needing to add the Underscore function in the downstreams and also allows for potential cases where they're not derivable for some reason.
Instead of modifying DefaultBasePaths and then pulling values from it, the new approach pulls the baseUrl directly from the product and modifies it for mtls/universe domain immediately.
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.