modify existing generated deletion policy implementations for universal deletion policy by NickElliot · Pull Request #17003 · GoogleCloudPlatform/magic-modules

NickElliot · 2026-04-07T19:38:52Z

Release Note Template for Downstream PRs (will be copied)

modular-magician · 2026-04-07T19:48:57Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 47 files changed, 663 insertions(+), 310 deletions(-))
google-beta provider: Diff ( 57 files changed, 893 insertions(+), 448 deletions(-))
terraform-google-conversion: Diff ( 7 files changed, 50 insertions(+), 28 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Field deletion_policy default value changed from ABANDON to <nil> on google_firestore_database - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_alloydb_cluster - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_chronicle_data_table - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_chronicle_rule - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_firebase_data_connect_service - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_looker_instance - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_netapp_volume - reference
Field deletion_policy default value changed from DELETE to <nil> on google_container_attached_cluster - reference
Field deletion_policy default value changed from DELETE to <nil> on google_dataform_repository - reference
Field deletion_policy default value changed from DELETE to <nil> on google_firebase_android_app - reference
Field deletion_policy default value changed from DELETE to <nil> on google_firebase_apple_app - reference
Field deletion_policy default value changed from DELETE to <nil> on google_firebase_web_app - reference
Field deletion_policy default value changed from DELETE to <nil> on google_firestore_index - reference
Field deletion_policy default value changed from DELETE to <nil> on google_secret_manager_regional_secret_version - reference
Field deletion_policy default value changed from DELETE to <nil> on google_secret_manager_secret_version - reference
Field deletion_policy default value changed from DELETE to <nil> on google_sql_database - reference
Field deletion_policy default value changed from PREVENT to <nil> on google_secure_source_manager_instance - reference
Field deletion_policy default value changed from PREVENT to <nil> on google_secure_source_manager_repository - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

modular-magician · 2026-04-07T21:11:12Z

Tests analytics

Total tests: 609
Passed tests: 503
Skipped tests: 41
Affected tests: 65

Click here to see the affected service packages

dataform

firebase

firestore

looker

netapp

secretmanager

chronicle

firebasedataconnect

secretmanagerregional

securesourcemanager

sql

vertexai

alloydb

containerattached

Action taken

Found 65 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAlloydbCluster_alloydbClusterBasicExample

TestAccChronicleDataTable_DeletionPolicy_DefaultFail

TestAccDataSourceGoogleFirebaseAndroidApp

TestAccDataSourceGoogleFirebaseAndroidAppConfig

TestAccDataSourceGoogleFirebaseAppleApp

TestAccDataSourceGoogleFirebaseAppleAppConfig

TestAccDataSourceGoogleFirebaseWebApp

TestAccDataSourceGoogleFirebaseWebAppConfig

TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample

TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample

TestAccFirebaseAndroidApp_firebaseAndroidAppBasicExample

TestAccFirebaseAndroidApp_firebaseAndroidAppCustomApiKeyExample

TestAccFirebaseAndroidApp_update

TestAccFirebaseAppleApp_firebaseAppleAppBasicExample

TestAccFirebaseAppleApp_firebaseAppleAppFullExample

TestAccFirebaseAppleApp_update

TestAccFirebaseDataConnectService_firebasedataconnectServiceBasicExample

TestAccFirebaseDataConnectService_firebasedataconnectServiceWithForceDeletionExample

TestAccFirebaseWebApp_firebaseWebAppBasicExample

TestAccFirebaseWebApp_firebaseWebAppCustomApiKeyExample

TestAccFirebaseWebApp_firebaseWebAppFull

TestAccFirestoreBackupSchedule_firestoreBackupScheduleDailyExample

TestAccFirestoreBackupSchedule_firestoreBackupScheduleWeeklyExample

TestAccFirestoreDatabase_firestoreCmekDatabaseExample

TestAccFirestoreDatabase_firestoreCmekDatabaseInDatastoreModeExample

TestAccFirestoreDocument_firestoreDocumentBasicExample

TestAccFirestoreDocument_firestoreDocumentNestedDocumentExample

TestAccFirestoreField_firestoreFieldBasicExample

TestAccFirestoreField_firestoreFieldMatchOverrideExample

TestAccFirestoreField_firestoreFieldTimestampExample

TestAccFirestoreField_firestoreFieldWildcardExample

TestAccFirestoreIndex_firestoreIndexBasicExample

TestAccFirestoreIndex_firestoreIndexDatastoreModeExample

TestAccFirestoreIndex_firestoreIndexDeletionPolicyExample

TestAccFirestoreIndex_firestoreIndexMongodbCompatibleScopeExample

TestAccFirestoreIndex_firestoreIndexNameDescendingExample

TestAccFirestoreIndex_firestoreIndexSkipWaitExample

TestAccFirestoreIndex_firestoreIndexSparseAnyExample

TestAccFirestoreIndex_firestoreIndexUniqueExample

TestAccFirestoreIndex_firestoreIndexVectorExample

TestAccFirestoreUserCreds_firestoreUserCredsBasicExample

TestAccFirestoreUserCreds_firestoreUserCredsWithSecretManagerExample

TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample

TestAccNetappBackup_netappBackupExample

TestAccNetappVolumeQuotaRule_netappVolumeQuotaRuleBasicExample

TestAccNetappVolumeReplication_netappVolumeReplicationCreateExample

TestAccNetappVolumeSnapshot_volumeSnapshotCreateExample

TestAccNetappVolume_netappVolumeBasicExample

TestAccSQLDatabase_sqlDatabaseBasicExample

TestAccSQLDatabase_sqlDatabaseDeletionPolicyExample

TestAccSecretManagerSecret_secretWithAutomaticCmekExample

TestAccSecureSourceManagerBranchRule_secureSourceManagerBranchRuleBasicExample

TestAccSecureSourceManagerBranchRule_secureSourceManagerBranchRuleWithFieldsExample

TestAccSecureSourceManagerHook_secureSourceManagerHookBasicExample

TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample

TestAccSecureSourceManagerInstance_secureSourceManagerInstanceCmekExample

TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivateCustomHostExample

TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivateExample

TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscEndpointExample

TestAccSecureSourceManagerRepository_secureSourceManagerRepositoryBasicExample

TestAccSecureSourceManagerRepository_secureSourceManagerRepositoryInitialConfigExample

TestAccVertexAIReasoningEngine_vertexAiReasoningEngineDeveloperConnectSourceExample

TestAccVertexAIReasoningEngine_vertexAiReasoningEngineSourceBasedDeploymentExample

TestAccVertexAIReasoningEngine_vertexAiReasoningEngineSourceUpdate

Get to know how VCR tests work

modular-magician · 2026-04-07T23:05:12Z

🟢 Tests passed during RECORDING mode:
TestAccAlloydbCluster_alloydbClusterBasicExample [Debug log]
TestAccDataSourceGoogleFirebaseAndroidApp [Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig [Debug log]
TestAccDataSourceGoogleFirebaseAppleApp [Debug log]
TestAccDataSourceGoogleFirebaseWebApp [Debug log]
TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample [Debug log]
TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample [Debug log]
TestAccFirebaseAndroidApp_update [Debug log]
TestAccFirebaseAppleApp_update [Debug log]
TestAccFirebaseDataConnectService_firebasedataconnectServiceBasicExample [Debug log]
TestAccFirebaseDataConnectService_firebasedataconnectServiceWithForceDeletionExample [Debug log]
TestAccFirebaseWebApp_firebaseWebAppFull [Debug log]
TestAccFirestoreBackupSchedule_firestoreBackupScheduleDailyExample [Debug log]
TestAccFirestoreBackupSchedule_firestoreBackupScheduleWeeklyExample [Debug log]
TestAccFirestoreDatabase_firestoreCmekDatabaseExample [Debug log]
TestAccFirestoreDatabase_firestoreCmekDatabaseInDatastoreModeExample [Debug log]
TestAccFirestoreDocument_firestoreDocumentBasicExample [Debug log]
TestAccFirestoreDocument_firestoreDocumentNestedDocumentExample [Debug log]
TestAccFirestoreField_firestoreFieldBasicExample [Debug log]
TestAccFirestoreField_firestoreFieldMatchOverrideExample [Debug log]
TestAccFirestoreField_firestoreFieldTimestampExample [Debug log]
TestAccFirestoreField_firestoreFieldWildcardExample [Debug log]
TestAccFirestoreIndex_firestoreIndexBasicExample [Debug log]
TestAccFirestoreIndex_firestoreIndexDatastoreModeExample [Debug log]
TestAccFirestoreIndex_firestoreIndexDeletionPolicyExample [Debug log]
TestAccFirestoreIndex_firestoreIndexMongodbCompatibleScopeExample [Debug log]
TestAccFirestoreIndex_firestoreIndexNameDescendingExample [Debug log]
TestAccFirestoreIndex_firestoreIndexSkipWaitExample [Debug log]
TestAccFirestoreIndex_firestoreIndexSparseAnyExample [Debug log]
TestAccFirestoreIndex_firestoreIndexUniqueExample [Debug log]
TestAccFirestoreIndex_firestoreIndexVectorExample [Debug log]
TestAccFirestoreUserCreds_firestoreUserCredsBasicExample [Debug log]
TestAccFirestoreUserCreds_firestoreUserCredsWithSecretManagerExample [Debug log]
TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample [Debug log]
TestAccNetappBackup_netappBackupExample [Debug log]
TestAccNetappVolumeQuotaRule_netappVolumeQuotaRuleBasicExample [Debug log]
TestAccNetappVolumeReplication_netappVolumeReplicationCreateExample [Debug log]
TestAccNetappVolumeSnapshot_volumeSnapshotCreateExample [Debug log]
TestAccNetappVolume_netappVolumeBasicExample [Debug log]
TestAccSQLDatabase_sqlDatabaseBasicExample [Debug log]
TestAccSQLDatabase_sqlDatabaseDeletionPolicyExample [Debug log]
TestAccSecretManagerSecret_secretWithAutomaticCmekExample [Debug log]
TestAccSecureSourceManagerBranchRule_secureSourceManagerBranchRuleBasicExample [Debug log]
TestAccSecureSourceManagerBranchRule_secureSourceManagerBranchRuleWithFieldsExample [Debug log]
TestAccSecureSourceManagerHook_secureSourceManagerHookBasicExample [Debug log]
TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample [Debug log]
TestAccSecureSourceManagerInstance_secureSourceManagerInstanceCmekExample [Debug log]
TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivateCustomHostExample [Debug log]
TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivateExample [Debug log]
TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample [Debug log]
TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscEndpointExample [Debug log]
TestAccSecureSourceManagerRepository_secureSourceManagerRepositoryBasicExample [Debug log]
TestAccSecureSourceManagerRepository_secureSourceManagerRepositoryInitialConfigExample [Debug log]
TestAccVertexAIReasoningEngine_vertexAiReasoningEngineDeveloperConnectSourceExample [Debug log]
TestAccVertexAIReasoningEngine_vertexAiReasoningEngineSourceBasedDeploymentExample [Debug log]
TestAccVertexAIReasoningEngine_vertexAiReasoningEngineSourceUpdate [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccChronicleDataTable_DeletionPolicy_DefaultFail [Error message] [Debug log]
TestAccDataSourceGoogleFirebaseAppleAppConfig [Error message] [Debug log]
TestAccDataSourceGoogleFirebaseWebAppConfig [Error message] [Debug log]
TestAccFirebaseAndroidApp_firebaseAndroidAppBasicExample [Error message] [Debug log]
TestAccFirebaseAndroidApp_firebaseAndroidAppCustomApiKeyExample [Error message] [Debug log]
TestAccFirebaseAppleApp_firebaseAppleAppBasicExample [Error message] [Debug log]
TestAccFirebaseAppleApp_firebaseAppleAppFullExample [Error message] [Debug log]
TestAccFirebaseWebApp_firebaseWebAppBasicExample [Error message] [Debug log]
TestAccFirebaseWebApp_firebaseWebAppCustomApiKeyExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2026-04-08T19:53:02Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 47 files changed, 669 insertions(+), 316 deletions(-))
google-beta provider: Diff ( 57 files changed, 899 insertions(+), 454 deletions(-))
terraform-google-conversion: Diff ( 7 files changed, 50 insertions(+), 28 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Field deletion_policy default value changed from ABANDON to <nil> on google_firestore_database - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_alloydb_cluster - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_chronicle_data_table - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_chronicle_rule - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_firebase_data_connect_service - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_looker_instance - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_netapp_volume - reference
Field deletion_policy default value changed from DELETE to <nil> on google_container_attached_cluster - reference
Field deletion_policy default value changed from DELETE to <nil> on google_dataform_repository - reference
Field deletion_policy default value changed from DELETE to <nil> on google_firebase_android_app - reference
Field deletion_policy default value changed from DELETE to <nil> on google_firebase_apple_app - reference
Field deletion_policy default value changed from DELETE to <nil> on google_firebase_web_app - reference
Field deletion_policy default value changed from DELETE to <nil> on google_firestore_index - reference
Field deletion_policy default value changed from DELETE to <nil> on google_secret_manager_regional_secret_version - reference
Field deletion_policy default value changed from DELETE to <nil> on google_secret_manager_secret_version - reference
Field deletion_policy default value changed from DELETE to <nil> on google_sql_database - reference
Field deletion_policy default value changed from PREVENT to <nil> on google_secure_source_manager_instance - reference
Field deletion_policy default value changed from PREVENT to <nil> on google_secure_source_manager_repository - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

modular-magician · 2026-04-08T21:16:52Z

Tests analytics

Total tests: 609
Passed tests: 551
Skipped tests: 41
Affected tests: 17

Click here to see the affected service packages

containerattached

dataform

firebase

firestore

secretmanager

sql

chronicle

firebasedataconnect

looker

netapp

secretmanagerregional

securesourcemanager

vertexai

alloydb

Action taken

Found 17 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccChronicleDataTable_DeletionPolicy_DefaultFail

TestAccDataSourceGoogleFirebaseAppleAppConfig

TestAccDataSourceGoogleFirebaseWebAppConfig

TestAccDataformConfig_update

TestAccFirebaseAndroidApp_firebaseAndroidAppBasicExample

TestAccFirebaseAndroidApp_firebaseAndroidAppCustomApiKeyExample

TestAccFirebaseAppleApp_firebaseAppleAppBasicExample

TestAccFirebaseAppleApp_firebaseAppleAppFullExample

TestAccFirebaseWebApp_firebaseWebAppBasicExample

TestAccFirebaseWebApp_firebaseWebAppCustomApiKeyExample

TestAccVertexAIReasoningEngine_vertexAiReasoningEngineBasicExample

TestAccVertexAIReasoningEngine_vertexAiReasoningEngineContextSpecExample

TestAccVertexAIReasoningEngine_vertexAiReasoningEngineDeletionPolicyExample

TestAccVertexAIReasoningEngine_vertexAiReasoningEngineFullExample

TestAccVertexAIReasoningEngine_vertexAiReasoningEngineGranularTtlExample

TestAccVertexAIReasoningEngine_vertexAiReasoningEngineIdentityTypeUpdate

TestAccVertexAIReasoningEngine_vertexAiReasoningEngineUpdate

Get to know how VCR tests work

modular-magician · 2026-04-08T21:40:48Z

🟢 Tests passed during RECORDING mode:
TestAccDataformConfig_update [Debug log]
TestAccVertexAIReasoningEngine_vertexAiReasoningEngineBasicExample [Debug log]
TestAccVertexAIReasoningEngine_vertexAiReasoningEngineContextSpecExample [Debug log]
TestAccVertexAIReasoningEngine_vertexAiReasoningEngineDeletionPolicyExample [Debug log]
TestAccVertexAIReasoningEngine_vertexAiReasoningEngineFullExample [Debug log]
TestAccVertexAIReasoningEngine_vertexAiReasoningEngineGranularTtlExample [Debug log]
TestAccVertexAIReasoningEngine_vertexAiReasoningEngineIdentityTypeUpdate [Debug log]
TestAccVertexAIReasoningEngine_vertexAiReasoningEngineUpdate [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccChronicleDataTable_DeletionPolicy_DefaultFail [Error message] [Debug log]
TestAccDataSourceGoogleFirebaseAppleAppConfig [Error message] [Debug log]
TestAccDataSourceGoogleFirebaseWebAppConfig [Error message] [Debug log]
TestAccFirebaseAndroidApp_firebaseAndroidAppBasicExample [Error message] [Debug log]
TestAccFirebaseAndroidApp_firebaseAndroidAppCustomApiKeyExample [Error message] [Debug log]
TestAccFirebaseAppleApp_firebaseAppleAppBasicExample [Error message] [Debug log]
TestAccFirebaseAppleApp_firebaseAppleAppFullExample [Error message] [Debug log]
TestAccFirebaseWebApp_firebaseWebAppBasicExample [Error message] [Debug log]
TestAccFirebaseWebApp_firebaseWebAppCustomApiKeyExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

NickElliot · 2026-04-20T20:25:11Z

TestAccChronicleDataTable_DeletionPolicy_DefaultFail failure is unrelated, has failed on a couple other PRs and it can be seen in debug log that the ?force=true was not included in the delete

NickElliot · 2026-04-20T20:27:13Z

sending out these last couple reviews around subteam as mentioned in our meeting earlier, let me know if there are any questions!

modular-magician · 2026-04-20T20:33:45Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 47 files changed, 669 insertions(+), 316 deletions(-))
google-beta provider: Diff ( 57 files changed, 899 insertions(+), 454 deletions(-))
terraform-google-conversion: Diff ( 7 files changed, 50 insertions(+), 28 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Field deletion_policy default value changed from ABANDON to <nil> on google_firestore_database - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_alloydb_cluster - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_chronicle_data_table - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_chronicle_rule - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_firebase_data_connect_service - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_looker_instance - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_netapp_volume - reference
Field deletion_policy default value changed from DELETE to <nil> on google_container_attached_cluster - reference
Field deletion_policy default value changed from DELETE to <nil> on google_dataform_repository - reference
Field deletion_policy default value changed from DELETE to <nil> on google_firebase_android_app - reference
Field deletion_policy default value changed from DELETE to <nil> on google_firebase_apple_app - reference
Field deletion_policy default value changed from DELETE to <nil> on google_firebase_web_app - reference
Field deletion_policy default value changed from DELETE to <nil> on google_firestore_index - reference
Field deletion_policy default value changed from DELETE to <nil> on google_secret_manager_regional_secret_version - reference
Field deletion_policy default value changed from DELETE to <nil> on google_secret_manager_secret_version - reference
Field deletion_policy default value changed from DELETE to <nil> on google_sql_database - reference
Field deletion_policy default value changed from PREVENT to <nil> on google_secure_source_manager_instance - reference
Field deletion_policy default value changed from PREVENT to <nil> on google_secure_source_manager_repository - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

modular-magician · 2026-04-20T21:57:23Z

Tests analytics

Total tests: 609
Passed tests: 550
Skipped tests: 41
Affected tests: 18

Click here to see the affected service packages

firestore

looker

secretmanager

secretmanagerregional

alloydb

chronicle

firebase

netapp

securesourcemanager

sql

vertexai

containerattached

dataform

firebasedataconnect

Action taken

Found 18 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAlloydbCluster_withMaintenanceWindows

TestAccAlloydbInstance_ObservabilityConfig_Update

TestAccAlloydbInstance_clientConnectionConfig

TestAccAlloydbInstance_networkConfig

TestAccAlloydbInstance_secondaryInstanceUpdateQueryInsightConfig

TestAccAlloydbInstance_update

TestAccChronicleDataTable_DeletionPolicy_DefaultFail

TestAccDataSourceGoogleFirebaseAppleAppConfig

TestAccDataSourceGoogleFirebaseWebAppConfig

TestAccDataformFolder_dataformFolderFullExample

TestAccFirebaseAndroidApp_firebaseAndroidAppBasicExample

TestAccFirebaseAndroidApp_firebaseAndroidAppCustomApiKeyExample

TestAccFirebaseAppleApp_firebaseAppleAppBasicExample

TestAccFirebaseAppleApp_firebaseAppleAppFullExample

TestAccFirebaseWebApp_firebaseWebAppBasicExample

TestAccFirebaseWebApp_firebaseWebAppCustomApiKeyExample

TestAccSqlDatabaseInstance_SqlServerAuditOptionalBucket

TestAccSqlDatabaseInstance_Timezone

Get to know how VCR tests work

modular-magician · 2026-04-20T22:43:50Z

🟢 Tests passed during RECORDING mode:
TestAccAlloydbCluster_withMaintenanceWindows [Debug log]
TestAccAlloydbInstance_ObservabilityConfig_Update [Debug log]
TestAccAlloydbInstance_clientConnectionConfig [Debug log]
TestAccAlloydbInstance_networkConfig [Debug log]
TestAccAlloydbInstance_secondaryInstanceUpdateQueryInsightConfig [Debug log]
TestAccAlloydbInstance_update [Debug log]
TestAccDataformFolder_dataformFolderFullExample [Debug log]
TestAccSqlDatabaseInstance_SqlServerAuditOptionalBucket [Debug log]
TestAccSqlDatabaseInstance_Timezone [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccChronicleDataTable_DeletionPolicy_DefaultFail [Error message] [Debug log]
TestAccDataSourceGoogleFirebaseAppleAppConfig [Error message] [Debug log]
TestAccDataSourceGoogleFirebaseWebAppConfig [Error message] [Debug log]
TestAccFirebaseAndroidApp_firebaseAndroidAppBasicExample [Error message] [Debug log]
TestAccFirebaseAndroidApp_firebaseAndroidAppCustomApiKeyExample [Error message] [Debug log]
TestAccFirebaseAppleApp_firebaseAppleAppBasicExample [Error message] [Debug log]
TestAccFirebaseAppleApp_firebaseAppleAppFullExample [Error message] [Debug log]
TestAccFirebaseWebApp_firebaseWebAppBasicExample [Error message] [Debug log]
TestAccFirebaseWebApp_firebaseWebAppCustomApiKeyExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

zli82016

The failed tests TestAccDataSourceGoogleFirebase, TestAccFirebaseAndroidApp, TestAccFirebaseAppleApp and TestAccFirebaseWebApp seems related.
Do we need to set the field deletion_policy during importing? The existing set is removed.
https://github.com/modular-magician/terraform-provider-google-beta/compare/d106fb231ae624716a8ef91944a99beee36a8a62..ea6fadb66d8dd5e79be9bae1f77db3e4d2929465#diff-fd2fa1877ce2e3a49f800f3415efe42a4301dea460f276c751e4d45e63fbf8afL500
There is an error in unit test
Error: google/services/networkconnectivity/resource_network_connectivity_transport_test.go:65:29: undefined: testAccCheckNetworkConnectivityTransportDestroyProducer

modular-magician · 2026-04-21T19:43:56Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 47 files changed, 669 insertions(+), 316 deletions(-))
google-beta provider: Diff ( 57 files changed, 869 insertions(+), 394 deletions(-))
terraform-google-conversion: Diff ( 7 files changed, 50 insertions(+), 28 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Field deletion_policy default value changed from ABANDON to <nil> on google_firestore_database - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_alloydb_cluster - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_chronicle_data_table - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_chronicle_rule - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_firebase_data_connect_service - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_looker_instance - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_netapp_volume - reference
Field deletion_policy default value changed from DELETE to <nil> on google_container_attached_cluster - reference
Field deletion_policy default value changed from DELETE to <nil> on google_dataform_repository - reference
Field deletion_policy default value changed from DELETE to <nil> on google_firebase_android_app - reference
Field deletion_policy default value changed from DELETE to <nil> on google_firebase_apple_app - reference
Field deletion_policy default value changed from DELETE to <nil> on google_firebase_web_app - reference
Field deletion_policy default value changed from DELETE to <nil> on google_firestore_index - reference
Field deletion_policy default value changed from DELETE to <nil> on google_secret_manager_regional_secret_version - reference
Field deletion_policy default value changed from DELETE to <nil> on google_secret_manager_secret_version - reference
Field deletion_policy default value changed from DELETE to <nil> on google_sql_database - reference
Field deletion_policy default value changed from PREVENT to <nil> on google_secure_source_manager_instance - reference
Field deletion_policy default value changed from PREVENT to <nil> on google_secure_source_manager_repository - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

modular-magician · 2026-04-21T19:50:05Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 47 files changed, 669 insertions(+), 316 deletions(-))
google-beta provider: Diff ( 57 files changed, 869 insertions(+), 394 deletions(-))
terraform-google-conversion: Diff ( 7 files changed, 50 insertions(+), 28 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Field deletion_policy default value changed from ABANDON to <nil> on google_firestore_database - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_alloydb_cluster - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_chronicle_data_table - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_chronicle_rule - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_firebase_data_connect_service - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_looker_instance - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_netapp_volume - reference
Field deletion_policy default value changed from DELETE to <nil> on google_container_attached_cluster - reference
Field deletion_policy default value changed from DELETE to <nil> on google_dataform_repository - reference
Field deletion_policy default value changed from DELETE to <nil> on google_firebase_android_app - reference
Field deletion_policy default value changed from DELETE to <nil> on google_firebase_apple_app - reference
Field deletion_policy default value changed from DELETE to <nil> on google_firebase_web_app - reference
Field deletion_policy default value changed from DELETE to <nil> on google_firestore_index - reference
Field deletion_policy default value changed from DELETE to <nil> on google_secret_manager_regional_secret_version - reference
Field deletion_policy default value changed from DELETE to <nil> on google_secret_manager_secret_version - reference
Field deletion_policy default value changed from DELETE to <nil> on google_sql_database - reference
Field deletion_policy default value changed from PREVENT to <nil> on google_secure_source_manager_instance - reference
Field deletion_policy default value changed from PREVENT to <nil> on google_secure_source_manager_repository - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

modular-magician · 2026-04-21T21:07:50Z

Tests analytics

Total tests: 609
Passed tests: 557
Skipped tests: 41
Affected tests: 11

Click here to see the affected service packages

vertexai

chronicle

dataform

firebase

firebasedataconnect

firestore

looker

netapp

securesourcemanager

alloydb

containerattached

secretmanager

secretmanagerregional

sql

Action taken

Found 11 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccChronicleDataTable_DeletionPolicy_DefaultFail

TestAccDataSourceGoogleFirebaseAndroidApp

TestAccDataSourceGoogleFirebaseAndroidAppConfig

TestAccDataSourceGoogleFirebaseAppleApp

TestAccDataSourceGoogleFirebaseWebApp

TestAccFirebaseAndroidApp_update

TestAccFirebaseAppleApp_firebaseAppleAppFullExample

TestAccFirebaseAppleApp_update

TestAccFirebaseWebApp_firebaseWebAppBasicExample

TestAccFirebaseWebApp_firebaseWebAppCustomApiKeyExample

TestAccFirebaseWebApp_firebaseWebAppFull

Get to know how VCR tests work

modular-magician · 2026-04-21T21:10:29Z

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleFirebaseAndroidApp [Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig [Debug log]
TestAccDataSourceGoogleFirebaseAppleApp [Debug log]
TestAccDataSourceGoogleFirebaseWebApp [Debug log]
TestAccFirebaseAndroidApp_update [Debug log]
TestAccFirebaseAppleApp_firebaseAppleAppFullExample [Debug log]
TestAccFirebaseWebApp_firebaseWebAppBasicExample [Debug log]
TestAccFirebaseWebApp_firebaseWebAppCustomApiKeyExample [Debug log]
TestAccFirebaseWebApp_firebaseWebAppFull [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccChronicleDataTable_DeletionPolicy_DefaultFail [Error message] [Debug log]
TestAccFirebaseAppleApp_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2026-04-21T21:13:57Z

Tests analytics

Total tests: 609
Passed tests: 556
Skipped tests: 41
Affected tests: 12

Click here to see the affected service packages

alloydb

chronicle

containerattached

dataform

firebase

netapp

secretmanagerregional

firebasedataconnect

firestore

looker

secretmanager

securesourcemanager

sql

vertexai

Action taken

Found 12 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccChronicleDataTable_DeletionPolicy_DefaultFail

TestAccDataSourceGoogleFirebaseAndroidApp

TestAccDataSourceGoogleFirebaseAndroidAppConfig

TestAccDataSourceGoogleFirebaseAppleApp

TestAccDataSourceGoogleFirebaseWebApp

TestAccDataformConfig_update

TestAccFirebaseAndroidApp_update

TestAccFirebaseAppleApp_firebaseAppleAppFullExample

TestAccFirebaseAppleApp_update

TestAccFirebaseWebApp_firebaseWebAppBasicExample

TestAccFirebaseWebApp_firebaseWebAppCustomApiKeyExample

TestAccFirebaseWebApp_firebaseWebAppFull

Get to know how VCR tests work

modular-magician · 2026-04-21T21:19:44Z

🟢 Tests passed during RECORDING mode:
TestAccChronicleDataTable_DeletionPolicy_DefaultFail [Debug log]
TestAccDataSourceGoogleFirebaseAndroidApp [Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig [Debug log]
TestAccDataSourceGoogleFirebaseAppleApp [Debug log]
TestAccDataSourceGoogleFirebaseWebApp [Debug log]
TestAccDataformConfig_update [Debug log]
TestAccFirebaseAndroidApp_update [Debug log]
TestAccFirebaseAppleApp_firebaseAppleAppFullExample [Debug log]
TestAccFirebaseWebApp_firebaseWebAppBasicExample [Debug log]
TestAccFirebaseWebApp_firebaseWebAppCustomApiKeyExample [Debug log]
TestAccFirebaseWebApp_firebaseWebAppFull [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccFirebaseAppleApp_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician added the service/terraform label Apr 7, 2026

NickElliot added 2 commits April 8, 2026 12:42

implement flags for modifying existing implementations

4e0360d

modify generated pre existing implementations

c794765

NickElliot force-pushed the udpexisting branch from 0cae981 to c794765 Compare April 8, 2026 19:43

yamllint

232fb75

NickElliot marked this pull request as ready for review April 20, 2026 20:25

NickElliot requested a review from zli82016 April 20, 2026 20:25

zli82016 requested changes Apr 21, 2026

View reviewed changes

Comment thread mmv1/templates/terraform/resource.go.tmpl Outdated

NickElliot added 2 commits April 21, 2026 12:33

re add custom deletes

44fcbcb

add docs link

b80c9b3

NickElliot requested a review from zli82016 April 21, 2026 20:32

zli82016 approved these changes Apr 21, 2026

View reviewed changes

NickElliot merged commit a028559 into GoogleCloudPlatform:FEATURE-BRANCH-universal-deletion-policy Apr 22, 2026
20 of 23 checks passed

Conversation

NickElliot commented Apr 7, 2026

Uh oh!

modular-magician commented Apr 7, 2026

Diff report

Breaking Change(s) Detected

Uh oh!

modular-magician commented Apr 7, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 7, 2026

Uh oh!

modular-magician commented Apr 8, 2026

Diff report

Breaking Change(s) Detected

Uh oh!

modular-magician commented Apr 8, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 8, 2026

Uh oh!

NickElliot commented Apr 20, 2026

Uh oh!

NickElliot commented Apr 20, 2026

Uh oh!

modular-magician commented Apr 20, 2026

Diff report

Breaking Change(s) Detected

Uh oh!

modular-magician commented Apr 20, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 20, 2026

Uh oh!

zli82016 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

modular-magician commented Apr 21, 2026

Diff report

Breaking Change(s) Detected

Uh oh!

modular-magician commented Apr 21, 2026

Diff report

Breaking Change(s) Detected

Uh oh!

modular-magician commented Apr 21, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 21, 2026

Uh oh!

modular-magician commented Apr 21, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

zli82016 left a comment •

edited

Loading