Skip to content

[DLP] Deidentify table with two separate cryptographic hash transformations - #7980

Merged
annadata merged 8 commits into
GoogleCloudPlatform:mainfrom
bhavika-dhanwani:dlp_deidentify_table_with_multiple_crypto_hash
May 9, 2023
Merged

[DLP] Deidentify table with two separate cryptographic hash transformations#7980
annadata merged 8 commits into
GoogleCloudPlatform:mainfrom
bhavika-dhanwani:dlp_deidentify_table_with_multiple_crypto_hash

Conversation

@bhavika-dhanwani

@bhavika-dhanwani bhavika-dhanwani commented May 3, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Implemented Deidentify table with two separate cryptographic hash transformations

Checklist

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@bhavika-dhanwani
bhavika-dhanwani requested review from a team and yoshi-approver as code owners May 3, 2023 08:45
@snippet-bot

snippet-bot Bot commented May 3, 2023 •
edited
Loading

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label Bot added samples Issues that are directly related to samples. api: dlp Issues related to the Sensitive Data Protection API. labels May 3, 2023
@bhavika-dhanwani
Merge branch 'main' of https://github.com/bhavika-dhanwani/java-docs-…
3ad9cae 
…samples into dlp_deidentify_table_with_multiple_crypto_hash

# Conflicts:
#	dlp/snippets/src/test/java/dlp/snippets/DeIdentificationTests.java
@averikitsch averikitsch added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 3, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 3, 2023
@Shabirmean

Shabirmean commented May 3, 2023

Copy link
Copy Markdown
Contributor

@bhavika-dhanwani - please rebase with main to be merge this in

@bhavika-dhanwani

bhavika-dhanwani commented May 4, 2023

Copy link
Copy Markdown
Contributor Author

@bhavika-dhanwani - please rebase with main to be merge this in

Done

@Sita04 Sita04 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 5, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 5, 2023
annadata
annadata approved these changes May 6, 2023
View reviewed changes

@annadata annadata left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pl address review comments.

Comment thread dlp/snippets/src/test/java/dlp/snippets/DeIdentificationTests.java Outdated
Comment thread dlp/snippets/src/main/java/dlp/snippets/DeIdentifyTableWithMultipleCryptoHash.java Outdated
@annadata annadata assigned annadata and unassigned ivanmed May 6, 2023
@averikitsch averikitsch added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 8, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 8, 2023
@annadata annadata added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 9, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 9, 2023
@annadata
annadata merged commit a79934b into GoogleCloudPlatform:main May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@annadata annadata annadata approved these changes
@Sita04 Sita04 Sita04 approved these changes
@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver is a code owner

Assignees

@annadata annadata

Labels

api: dlp Issues related to the Sensitive Data Protection API. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@bhavika-dhanwani @Shabirmean @annadata @Sita04 @averikitsch @kokoro-team @ivanmed @catherinerosesantos