Skip to content

Dc qc samples#7855

Merged
bonifacyj merged 14 commits into
mainfrom
dc-qc-samples
Apr 7, 2023
Merged

Dc qc samples#7855
bonifacyj merged 14 commits into
mainfrom
dc-qc-samples

Conversation

@bonifacyj
Copy link
Copy Markdown
Contributor

Bug fixes; add clarity to the sample

  • [Yes ] I have followed Sample Format Guide
  • [ Yes] pom.xml parent set to latest shared-configuration
  • [N/A ] Appropriate changes to README are included in PR
  • [No ] API's need to be enabled to test (tell us)
  • [ No] Environment Variables need to be set (ask us to set them)
  • [Yes ] Tests pass: mvn clean verify required
  • [Yes ] Lint passes: mvn -P lint checkstyle:check required
  • [Partially ] Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • [ Yes] Please merge this PR for me once it is approved.

@bonifacyj bonifacyj requested review from a team and yoshi-approver as code owners April 7, 2023 15:03
@product-auto-label product-auto-label Bot added samples Issues that are directly related to samples. api: datacatalog Issues related to the Data Catalog API. labels Apr 7, 2023
@KonstantinMi
Copy link
Copy Markdown

Looks good to me.

@bonifacyj bonifacyj merged commit b73d4a6 into main Apr 7, 2023
@bonifacyj bonifacyj deleted the dc-qc-samples branch April 7, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: datacatalog Issues related to the Data Catalog API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants