Skip to content

test: fix flaky asset tests#7517

Merged
averikitsch merged 9 commits into
mainfrom
issue-7446
Dec 19, 2022
Merged

test: fix flaky asset tests#7517
averikitsch merged 9 commits into
mainfrom
issue-7446

Conversation

@kweinmeister
Copy link
Copy Markdown
Contributor

@kweinmeister kweinmeister commented Dec 18, 2022

#7446 has continued to flake after retries were added. The following updates were made in this PR:

  • Tests will use a different Dataset ID or GCS path each retry. Whenever a timeout flake occurred, retries immediately failed with an INVALID_ARGUMENT exception. I believe that was because the resources were still in use.
  • A new, optional sample parameter for exporting specific asset types was introduced. This should hopefully reduce the export time, and therefore reduce the chance of timeouts. The tests now only export the Disk asset type.

Fixes #7446
Fixes #7456
Fixes #7476

@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label Dec 18, 2022
@kweinmeister kweinmeister changed the title test: debug asset test failures test: fix flaky asset tests Dec 18, 2022
@averikitsch averikitsch merged commit 1537ff1 into main Dec 19, 2022
@averikitsch averikitsch deleted the issue-7446 branch December 19, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

3 participants