Skip to content

Update AccessSecretVersion.java#7174

Merged
gcf-merge-on-green[bot] merged 1 commit into
GoogleCloudPlatform:mainfrom
nataliesalvati:patch-1
Jun 10, 2022
Merged

Update AccessSecretVersion.java#7174
gcf-merge-on-green[bot] merged 1 commit into
GoogleCloudPlatform:mainfrom
nataliesalvati:patch-1

Conversation

@nataliesalvati
Copy link
Copy Markdown
Contributor

@nataliesalvati nataliesalvati commented May 26, 2022

The previously linked library is deprecated, the guice implementation is favored now.

Fixes #issue

It's a good idea to open an issue first for discussion.

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • API's need to be enabled to test (tell us)
  • Environment Variables need to be set (ask us to set them)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • Please merge this PR for me once it is approved.

The previously linked library is deprecated, the guice implementation is favored now.
@nataliesalvati nataliesalvati requested review from a team and yoshi-approver as code owners May 26, 2022 20:23
@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label May 26, 2022
@stephaniewang526 stephaniewang526 removed their assignment Jun 2, 2022
@sethvargo sethvargo requested a review from tmatsuo June 9, 2022 15:30
@sethvargo
Copy link
Copy Markdown
Contributor

Hey @tmatsuo - could you help us find a reviewer for this?

@averikitsch averikitsch added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Jun 10, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 10, 2022
@sethvargo
Copy link
Copy Markdown
Contributor

Thanks @averikitsch !

@gcf-merge-on-green gcf-merge-on-green Bot merged commit ad66c47 into GoogleCloudPlatform:main Jun 10, 2022
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants