Skip to content

feat: add channel event resource code samples and tests - #7163

Merged
irataxy merged 1 commit into
GoogleCloudPlatform:mainfrom
irataxy:main
May 23, 2022
Merged

irataxy merged 1 commit into
GoogleCloudPlatform:mainfrom
irataxy:main

Conversation

@irataxy

@irataxy irataxy commented May 23, 2022 •

Copy link
Copy Markdown
Contributor

Fixes b:219762506
Final feature set

It's a good idea to open an issue first for discussion.

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • API's need to be enabled to test (tell us)
  • Environment Variables need to be set (ask us to set them)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • Please merge this PR for me once it is approved.

@irataxy
irataxy requested review from a team and yoshi-approver as code owners May 23, 2022 20:36
@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label May 23, 2022
@snippet-bot

snippet-bot Bot commented May 23, 2022

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@irataxy irataxy assigned kurtisvg and unassigned lesv May 23, 2022
@irataxy
irataxy merged commit 1278c48 into GoogleCloudPlatform:main May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants