Skip to content

fix: java 17 tests#7119

Merged
shubha-rajan merged 8 commits into
mainfrom
run-tests
May 18, 2022
Merged

fix: java 17 tests#7119
shubha-rajan merged 8 commits into
mainfrom
run-tests

Conversation

@averikitsch
Copy link
Copy Markdown
Contributor

@averikitsch averikitsch commented May 7, 2022

Fixes #7091

It's a good idea to open an issue first for discussion.

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • API's need to be enabled to test (tell us)
  • Environment Variables need to be set (ask us to set them)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • Please merge this PR for me once it is approved.

@averikitsch
Copy link
Copy Markdown
Contributor Author

@shubha-rajan if you have time can you take a look at and help with this?

@shubha-rajan
Copy link
Copy Markdown
Contributor

shubha-rajan commented May 9, 2022

@shubha-rajan if you have time can you take a look at and help with this?

Sure! I saw that you tried changing the fork count in a previous commit. I think you were on the right track but also need to add this line: <argLine>-Xmx1024m -XX:MaxPermSize=256m</argLine>

Source:
https://stackoverflow.com/questions/23260057/the-forked-vm-terminated-without-saying-properly-goodbye-vm-crash-or-system-exi

Sidenote: This is a bit concerning https://maven.apache.org/surefire/maven-surefire-plugin/faq.html#vm-termination

If this happens on a CI environment and only after it runs for some time, there is a fair chance your test suite is leaking some kind of OS-level resource that makes things worse at every run.

@averikitsch
Copy link
Copy Markdown
Contributor Author

For Java 17, the image needs to be updated. I've added a PR googleapis/testing-infra-docker#206. As for the potential leak, I unfortunately would lean towards waiting to see if we move to GitHub Actions before debugging Kokoro.

@averikitsch
Copy link
Copy Markdown
Contributor Author

The forks seem to be causing issues. We may need to skip the hello-broken tests for J17 since I need to set env vars for the tests and this is causing the main issue.

@meltsufin meltsufin added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 10, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 10, 2022
@meltsufin meltsufin added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 10, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 10, 2022
@shubha-rajan shubha-rajan added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 16, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 16, 2022
@averikitsch averikitsch force-pushed the run-tests branch 2 times, most recently from 08d39c7 to 61a302a Compare May 17, 2022 17:13
@averikitsch averikitsch force-pushed the run-tests branch 3 times, most recently from 0290cb4 to 904a339 Compare May 17, 2022 18:04
@averikitsch averikitsch requested a review from shubha-rajan May 17, 2022 21:17
@averikitsch averikitsch linked an issue May 17, 2022 that may be closed by this pull request
@shubha-rajan shubha-rajan merged commit f149410 into main May 18, 2022
@shubha-rajan shubha-rajan deleted the run-tests branch May 18, 2022 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

5 participants