Skip to content

docs(compute-samples): init add samples for custom hostname#6678

Merged
stephaniewang526 merged 1 commit into
mainfrom
gce-samples-custom-hostname
Jan 19, 2022
Merged

docs(compute-samples): init add samples for custom hostname#6678
stephaniewang526 merged 1 commit into
mainfrom
gce-samples-custom-hostname

Conversation

@Sita04
Copy link
Copy Markdown
Contributor

@Sita04 Sita04 commented Jan 19, 2022

Added samples for instance creation with custom hostname.

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • API's need to be enabled to test (tell us)
  • Environment Variables need to be set (ask us to set them)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • Please merge this PR for me once it is approved.

@Sita04 Sita04 requested review from a team and yoshi-approver as code owners January 19, 2022 08:21
@snippet-bot
Copy link
Copy Markdown

snippet-bot Bot commented Jan 19, 2022

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label Jan 19, 2022
@stephaniewang526 stephaniewang526 merged commit b623771 into main Jan 19, 2022
@stephaniewang526 stephaniewang526 deleted the gce-samples-custom-hostname branch January 19, 2022 16:26
Sita04 added a commit that referenced this pull request Jan 24, 2022
@Sita04
docs(compute-samples): init add samples for custom hostname (#6678)
c5cca6b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver is a code owner

1 more reviewer

@stephaniewang526 stephaniewang526 stephaniewang526 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@stephaniewang526 stephaniewang526

Labels

samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Sita04 @stephaniewang526