Inspect gcs sample b 157050959#3146
Merged
gcf-merge-on-green[bot] merged 3 commits intoGoogleCloudPlatform:masterfrom Jun 11, 2020
Merged
Inspect gcs sample b 157050959#3146gcf-merge-on-green[bot] merged 3 commits intoGoogleCloudPlatform:masterfrom
gcf-merge-on-green[bot] merged 3 commits intoGoogleCloudPlatform:masterfrom
Conversation
c292b16 to
1805e94
Compare
lesv
reviewed
Jun 11, 2020
| try { | ||
| done.get(15, TimeUnit.MINUTES); | ||
| } catch (TimeoutException e) { | ||
| System.out.println("Job was not completed after 15 minutes."); |
Contributor
There was a problem hiding this comment.
Is there something a user should do here?
Contributor
Author
There was a problem hiding this comment.
For now I'm keeping this consistent with the other existing samples. Obviously "println and return" is probably not the right answer for most prod systems, but it does keep the sample simple. Hopefully it's easy for users to tune to their own needs.
As a broader effort, it would be great to have a consistent approach to recommend across samples, across APIs, and (ideally) across languages as well.
lesv
approved these changes
Jun 11, 2020
Sita04
pushed a commit
that referenced
this pull request
Feb 7, 2023
Fixes internal bug b/157050959 - [X] I have followed [Sample Format Guide](https://github.com/GoogleCloudPlatform/java-docs-samples/blob/master/SAMPLE_FORMAT.md) - [X] `pom.xml` parent set to latest `shared-configuration` - [X] Appropriate changes to README are included in PR - [X] API's need to be enabled to test (tell us) (**Nothing new**) - [X] Environment Variables need to be set (ask us to set them) (**Nothing new**) - [X] **Tests** pass: `mvn clean verify` **required** - [X] **Lint** passes: `mvn -P lint checkstyle:check` **required** - [X] **Static Analysis**: `mvn -P lint clean compile pmd:cpd-check spotbugs:check` **advisory only** - [X] Please **merge** this PR for me once it is approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes internal bug b/157050959
pom.xmlparent set to latestshared-configurationmvn clean verifyrequiredmvn -P lint checkstyle:checkrequiredmvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory only