Skip to content

Add tests for Cloud Tasks app engine targets#1493

Merged
averikitsch merged 7 commits intomasterfrom
tasks-update
Jun 25, 2019
Merged

Add tests for Cloud Tasks app engine targets#1493
averikitsch merged 7 commits intomasterfrom
tasks-update

Conversation

@averikitsch
Copy link
Copy Markdown
Contributor

No description provided.

@averikitsch averikitsch requested a review from a team June 25, 2019 21:53
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 25, 2019
@averikitsch averikitsch requested a review from lesv June 25, 2019 22:45
<artifactId>google-cloud-tasks</artifactId>
<version>1.6.0</version>
<scope>provided</scope>
<version>1.3.0</version>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the roll back?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The library is broken, hence the added tests to catch this next time.

<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
<version>4.13-beta-2</version>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<scope>test</scope>

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. Thanks for the review.

@averikitsch averikitsch merged commit 13b4130 into master Jun 25, 2019
@averikitsch averikitsch deleted the tasks-update branch June 25, 2019 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants