Make "Build Project" complete successfully.#1242
Make "Build Project" complete successfully.#1242prafullkotecha wants to merge 4 commits intoGoogleCloudPlatform:masterfrom direkshan-digital:master
Conversation
kurtisvg
left a comment
There was a problem hiding this comment.
Thanks for taking the time to submit this. I left a couple of comments that need to be fixed before we can merge.
If you prefer, please enable us to push commits to this PR and I can make the adjustments.
| <dependency> | ||
| <groupId>com.google.appengine</groupId> | ||
| <artifactId>appengine-api-1.0-sdk</artifactId> | ||
| <version>RELEASE</version> |
There was a problem hiding this comment.
Please change from RELEASE to the latest version number instead (for all dependencies).
We have a tool that incrementally updates to ensure the samples are working correctly (it's not running for this project because it isn't linked in the main pom.)
| @@ -0,0 +1,28 @@ | |||
| package com.example.appengine; | |||
There was a problem hiding this comment.
This class doesn't seem necessary?
|
There are a variety of checkstyle violations as well - please see the Resultstore link in the checks section. |
@kurtisvg - How do I enable that? |
|
@kurtisvg - That is already enabled. See attached screenshot. |
|
@prafullkotecha What command were you using the build this that it failed? I thought maybe it had been skipped by the typical tests, but it looks like it's building correctly on the current master branch |
|
So it looks like there are mainly two folders in this PR that were changed I'm going to close this and guess it was resolved in a previous commit - if you are still having issues with this please let me know so we try to troubleshoot. Thanks! |
|
I still some issues in |
|
Can you provide any more info on the error? How are you attempting to compile? |
|
Ok so it looks like the pom itself didn't have the correct parent declared, so when running from the directory itself was creating an issue. I opened #1333 to address. If you can confirm this is the issue you are running into, that would be great. |
|
Yes. That's one of the issues. I have cloned the whole repo, and imported it as one big project, with multiple modules and module groups into intelliJ. Then, I just run |
Using "IntelliJ Idea CE". Build Project fails with bunch of compilation issues. This commit simply fixes errors, but doesn't address any of the warnings.