Skip to content

Create monitoring uptime check config samples.#1169

Merged
dzlier-gcp merged 2 commits into
GoogleCloudPlatform:masterfrom
dzlier-gcp:master
Aug 2, 2018
Merged

Create monitoring uptime check config samples.#1169
dzlier-gcp merged 2 commits into
GoogleCloudPlatform:masterfrom
dzlier-gcp:master

Conversation

@dzlier-gcp
Copy link
Copy Markdown
Member

Also organize the existing alert samples in a traditional directory, and clean up the code a bit.

The cleanup to AlertSample is just using a try() block to create the AlertPolicyClient or NotificationChannelServiceClient as needed instead of creating them for an instance of the AlertSample.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 1, 2018
kurtisvg
kurtisvg previously approved these changes Aug 1, 2018
Copy link
Copy Markdown
Contributor

@kurtisvg kurtisvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (minus checkstyle violations - A few lines are over the limit)

@dzlier-gcp
Copy link
Copy Markdown
Member Author

Crap, I had them all at 100 and then the review screen made it look like 120 was the limit.

@dzlier-gcp dzlier-gcp merged commit 2e5996c into GoogleCloudPlatform:master Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants