Add maven-exec-plugin info to tasks/pom.xml.#1155
Merged
Merged
Conversation
Member
Author
|
Can't seem to add Averi as a reviewer/assignee, cc'ing here. akitsch@google.com |
kurtisvg
previously approved these changes
Jul 16, 2018
kurtisvg
left a comment
Contributor
There was a problem hiding this comment.
One question, otherwise LGTM
| <plugin> | ||
| <groupId>org.codehaus.mojo</groupId> | ||
| <artifactId>exec-maven-plugin</artifactId> | ||
| <version>${maven-exec-plugin.version}</version> |
Contributor
There was a problem hiding this comment.
Does this need to be a property? I feel like there were some issues with DPEbot's auto updating properties, but I might be remembering incorrectly.
Member
Author
There was a problem hiding this comment.
I'm not sure. I can change it though, I was just copying from another sample in this repo that uses this plugin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just copying the pom.xml sections from appengine/tasks/pom.xml. These plugin fields allow
exec:javato complete without waiting for a loose thread from the tasks API. Otherwise, themvn exec:javacommand will hang and then fail.