Conversation
58cf2cc to
7b419ab
Compare
|
It is my mission to figure out this spanner error today. |
|
This beam error is still all messed up dependency-wise.
The newer Excluding that and using the previous version of spanner (0.20.0-beta) fails because apparently beam But allowing beam to use Seems to be a catch-22 here and I'm not sure what to do about it. I've tried other versions of spanner as well, such as the most recent beta ones, and they don't work either. I'm considering creating a bug (assigned to me for the time being) and skipping this test with @ignore for now. Thoughts? |
|
I think we should avoid updating the version number until we know the sample can pass. I would rather have an old version that runs than a new version that fails. If a user copies that pom.xml (either from here or in the docs), they may also run into the same issue. I would prefer to roll back the version upgrade and merge the other changes. |
|
@jabubake @jsimonweb - FYI since it deals with spanner |
|
@jsimonweb please look into what we need to do here |
270bd83 to
3ee31ee
Compare
|
Btw, I agree with @kurtisvg on not upgrading till the tests pass for the sample. @jsimonweb FYI |
|
I'm fine with that, just wanted to make sure it'd be OK to modify the auto update every friday to roll this back every time. Or is there an easier way to stop dpebot from updating the dependency? |
572164b to
7d88172
Compare
|
The rollback is intended to be temporary, this being a top priority issue at our end to fix. Lets see if we can make progress on fixing it this week. |
|
Removed the beam version update from the commit. |
|
It's possible to add an exception to DPEbot from updating certain dependencies, but probably not worthwhile in this case since it requires a commit to the repo and applies to all projects DPEbot monitors. |
Brought to you by your friendly Repository Gardener.