Skip to content

Auto-update dependencies.#1141

Merged
dzlier-gcp merged 2 commits intomasterfrom
dpebot-repositorygardener
Jun 25, 2018
Merged

Auto-update dependencies.#1141
dzlier-gcp merged 2 commits intomasterfrom
dpebot-repositorygardener

Conversation

@dpebot
Copy link
Copy Markdown
Contributor

@dpebot dpebot commented Jun 22, 2018

Brought to you by your friendly Repository Gardener.

@dpebot dpebot force-pushed the dpebot-repositorygardener branch from 58cf2cc to 7b419ab Compare June 22, 2018 02:38
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 22, 2018
@dzlier-gcp
Copy link
Copy Markdown
Member

It is my mission to figure out this spanner error today.

@dzlier-gcp
Copy link
Copy Markdown
Member

This beam error is still all messed up dependency-wise.

org.apache.beam:beam-sdks-java-io-google-cloud-platform:2.3.0 depends on com.google.cloud:google-cloud-spanner:0.20.0-beta.

The newer org.apache.beam:beam-sdks-java-io-google-cloud-platform:2.4.0 depends on com.google.cloud:google-cloud-spanner:*0.20.0b-beta*.

Excluding that and using the previous version of spanner (0.20.0-beta) fails because apparently beam 2.4.0 uses a new class PartitionOptions that was only introduced in 0.20.0b-beta.

But allowing beam to use 0.20.0b-beta causes the query failure where it says the root is not partitionable (even though running that query in the console passes just fine).

Seems to be a catch-22 here and I'm not sure what to do about it. I've tried other versions of spanner as well, such as the most recent beta ones, and they don't work either.

I'm considering creating a bug (assigned to me for the time being) and skipping this test with @ignore for now. Thoughts?

@kurtisvg
Copy link
Copy Markdown
Contributor

I think we should avoid updating the version number until we know the sample can pass. I would rather have an old version that runs than a new version that fails. If a user copies that pom.xml (either from here or in the docs), they may also run into the same issue.

I would prefer to roll back the version upgrade and merge the other changes.

@kurtisvg
Copy link
Copy Markdown
Contributor

@jabubake @jsimonweb - FYI since it deals with spanner

@jabubake
Copy link
Copy Markdown
Contributor

@jsimonweb please look into what we need to do here

@dpebot dpebot force-pushed the dpebot-repositorygardener branch 3 times, most recently from 270bd83 to 3ee31ee Compare June 25, 2018 02:38
@jabubake
Copy link
Copy Markdown
Contributor

Btw, I agree with @kurtisvg on not upgrading till the tests pass for the sample. @jsimonweb FYI

@dzlier-gcp
Copy link
Copy Markdown
Member

I'm fine with that, just wanted to make sure it'd be OK to modify the auto update every friday to roll this back every time. Or is there an easier way to stop dpebot from updating the dependency?

@dzlier-gcp dzlier-gcp force-pushed the dpebot-repositorygardener branch from 572164b to 7d88172 Compare June 25, 2018 16:06
@jabubake
Copy link
Copy Markdown
Contributor

The rollback is intended to be temporary, this being a top priority issue at our end to fix. Lets see if we can make progress on fixing it this week.

@dzlier-gcp
Copy link
Copy Markdown
Member

Removed the beam version update from the commit.

@kurtisvg
Copy link
Copy Markdown
Contributor

kurtisvg commented Jun 25, 2018

It's possible to add an exception to DPEbot from updating certain dependencies, but probably not worthwhile in this case since it requires a commit to the repo and applies to all projects DPEbot monitors.

@dzlier-gcp dzlier-gcp merged commit 84c6f3b into master Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants