Repository navigation
Change to endpoints managed rollout - #1054
Merged
simonz130 merged 10 commits intoApr 4, 2018
Merged
Conversation
Contributor
|
lesv
approved these changes
Mar 8, 2018
lesv
left a comment
Contributor
There was a problem hiding this comment.
LGTM - but it appears you need to fix a few things, so ping once that's done. Try doing a mvn clean verify before submitting. (It runs the style checker)
wmwong
suggested changes
Mar 28, 2018
wmwong
left a comment
Contributor
There was a problem hiding this comment.
The app.yaml files in getting-started/ and multiple-versions/ need to be updated as well (remove config id, add rollout_strategy managed).
lesv
reviewed
Apr 4, 2018
| ``` | ||
|
|
||
| 1. Edit `deployment.yaml`. Replace `SERVICE_NAME`, `SERVICE_CONFIG_ID`, and `GCLOUD_PROJECT` with your values. | ||
| 1. Edit `deployment.yaml`. Replace `SERVICE_NAME` and `GCLOUD_PROJECT` with your values. |
Contributor
There was a problem hiding this comment.
I'd prefer to see GOOGLE_CLOUD_PROJECT, but I won't block on it.
lesv
previously approved these changes
Apr 4, 2018
added 2 commits
April 3, 2018 19:06
wmwong
approved these changes
Apr 4, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We introduce a new feature where we can specify in YAML that service configuration for Endpoints is going to be managed. This means that the service will pull latest deployed service configuration automatically, rather than requiring customer to specify specific version of service configuration.
New flag:
--rollout_strategy=managed
Previously the only way to specify a version was using the following flag:
--version=SERVICE_CONFIG_ID