refactor(tts): Remove tts_synthesize_text_audio_profile duplicated region tag#10311
Draft
Kef131 wants to merge 2 commits into
Draft
refactor(tts): Remove tts_synthesize_text_audio_profile duplicated region tag#10311Kef131 wants to merge 2 commits into
tts_synthesize_text_audio_profile duplicated region tag#10311Kef131 wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the region tags for tts_synthesize_text_audio_profile in SynthesizeText.java. The review feedback points out that removing the start tag also removed a blank line, violating the Google Java Style Guide's vertical whitespace recommendation between class members, and suggests restoring it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #
b/536065373
Removes duplicated region tag
tts_synthesize_text_audio_profilefromtexttospeech/snippets/src/main/java/com/example/texttospeech/SynthesizeText.javato prevent region tag collisions and ensure accurate snippet mapping in documentation.NOTE: Don't remove file because it is used and linked to other region tags, which if neccessary will be treated in their own bug.
Checklist
Testing
mvn clean verifyrequiredmvn -P lint checkstyle:checkrequiredmvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory onlyCompliance & Style
pom.xmlparent set to latestshared-configurationPost-Approval Actions