Skip to content

fix(healthcare): remove old healthcare java dependency region tag PR Step 2/2#10283

Open
Kef131 wants to merge 1 commit into
mainfrom
fi(healthcare)-remove_old_regiontag_healthcare_dependencies
Open

fix(healthcare): remove old healthcare java dependency region tag PR Step 2/2#10283
Kef131 wants to merge 1 commit into
mainfrom
fi(healthcare)-remove_old_regiontag_healthcare_dependencies

Conversation

@Kef131

@Kef131 Kef131 commented Jun 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Fixes b/383619440

Remove old region tag dependencies to healthcare_java_dependencies in healthcare/v1/pom.xml.

Please do not merge, we will wait until CL propagation

Checklist

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • Tests pass: mvn clean verify required (Requires running gcert first to authenticate with Airlock to resolve dependencies)
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label Bot added api: healthcare Issues related to the Cloud Healthcare API API. samples Issues that are directly related to samples. api: healhcare labels Jun 17, 2026
@Kef131 Kef131 marked this pull request as ready for review June 17, 2026 18:08
@Kef131 Kef131 requested review from a team and yoshi-approver as code owners June 17, 2026 18:08
@snippet-bot

snippet-bot Bot commented Jun 17, 2026

Copy link
Copy Markdown

Here is the summary of changes.

You are about to delete 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jun 17, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request cleans up region tags in the healthcare/v1/pom.xml file by removing the inner dependencies tags. The reviewer correctly identified an issue where a duplicate healthcare_java_dependencies region tag pair wraps only the closing </dependencies> tag, which is invalid and will break documentation snippet extraction.

Comment thread healthcare/v1/pom.xml
@Kef131 Kef131 assigned Kef131 and unassigned dharmez Jun 17, 2026
amcolin
amcolin approved these changes Jun 17, 2026
View reviewed changes

@amcolin amcolin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look solid. We just need to merge them once the documentation pages reflect these updates as well.

@amcolin amcolin added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 17, 2026
@Kef131

Kef131 commented Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

The changes look solid. We just need to merge them once the documentation pages reflect these updates as well.

CL already merged, old region tag can be deleted.

@Kef131 Kef131 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amcolin amcolin amcolin approved these changes

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver is a code owner

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@Kef131 Kef131

Labels

api: healthcare Issues related to the Cloud Healthcare API API. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Kef131 @amcolin @dharmez